Mentorship-android: Create a mentorship relation task

[isabelcosta]

Description

As a user,
I need to create a new task for the relation,
so that I can register what my mentee's tasks are.

Make "Create a new task" action work with the Backend.

_Whoever takes this issue is free to enhance the issue and make it great in terms of UI look and feel._

Follow up of #121
Related to #132

Mocks

Acceptance Criteria

Update [Required]

• [ ] Create a new task dialog
• [ ] Call "Create Task" service from Backend REST API

Enhancement to Update [Optional]

• [ ] Show a loader?! indicating the api call

Definition of Done

• [ ] All of the required items are completed.
• [ ] Approval by 1 mentor.

Estimation

3 hours

[jenpaff]

can i have a go at this please ? @isabelcosta

[isabelcosta]

Sure @jenpaff ! But don't forget to finish the other PR. I just need you to fix the extra commits that are showing up on your PR.

[jenpaff]

@isabelcosta yes, of course! i reverted the commit! hope it's all good now

[isabelcosta]

@jenpaff ok I'll check that out

[jenpaff]

@isabelcosta íf it's okay I will start working on this, my other PR is already merged :)

[isabelcosta]

Yes you can work on that @jenpaff

[jenpaff]

@isabelcosta update: i'm gonna do some changes to the UI since I've got some ideas, is that okay? Just seen that #211 is depending on my issue

[isabelcosta]

Can you just give an idea of what you're planning to do, so that I or others can give some feedback (if it is a bug change in the UI) @jenpaff

[jenpaff]

sure ! i'll draw up a mock up and post it on slack @isabelcosta

[jenpaff]

@isabelcosta I've managed to create the feature, I only did very small UI changes: i created a new task dialog as mentioned in the issue and removed the horizontal line in between (see gif attached). The creating new tasks call is implemented and I'm ready to send you a PR, but how can I test if the data had been stored properly in the backend without having the get tasks method implemented yet?
I had a look at your swagger UI http://systers-mentorship-dev.eu-central-1.elasticbeanstalk.com/
I used /login with my user, I copied the access token in the response and called e.g. GET /mentorship_relation/{request_id}/tasks, but I get an 401 Unauthorized. Any help would be appreciated/feedback :)

[jenpaff]

hey! @isabelcosta can you please check my comment? I'd like to test my code properly before i send off a PR :) sorry for bothering you!

[isabelcosta]

@jenpaff I'll try to look at your comment this week, in the meanwhile post here a screens hot of all your input of this request and post it on slack to see if anyone from the community can help you out. No need to be sorry. It is OK to send reminders.

[isabelcosta]

@jenpaff here's at least 2 guides (links) I wrote about how to use our Swagger UI to test the backend, and there's also a live demonstration.
https://github.com/systers/mentorship-backend/wiki/Using-Backend-Swagger-UI
Can you also post here the fields you're giving as input to get the data you want?
@sidvenu can you also show me what are you putting in the input fields of swagger UI, in your respective issue?

[sidvenu]

@isabelcosta I must admit it, I thought the backend page was just for reference and for trying out different API points without an actual account... I did not know it is an actual interactive application that works just like in the app we are making.

Thanks for clearing it up!

[isabelcosta]

No problem! I'm really glad you understand that now ;)

That Swagger UI actually interacts with the backend code and database. You can register a user and perform all the actions you would in the current android app and can do even more. You'll be able to see Backend responses to your requests ;)
You can see this in my demo which is in the wiki page I shared. You can play a bit with it also if you want to understand more of the logic.

cc @sidvenu @jenpaff

[jenpaff]

@isabelcosta thanks, I only checked the mentorship-android wiki and didn't look through the backend-wiki. Either way, I made a very silly mistake, I forgot to add "Bearer " in front of the access token, that's why it was invalid ! Basically I finished the implementation and wanted to test if the tasks I'm creating are also stored in the database correctly . so when I add the task, and then I call /mentorship_relation/{request_id}/tasks with the correct mentorship relation id, I don't see any tasks.

[isabelcosta]

I'm glad you figured out what wasn't working 🎉

Regarding the List tasks feature, that is frozen for now, I know that would help both you and @sidvenu with your features.

132 is now available for contributors to take on, hopefully, someone can tackle this and unblock you both!

[jenpaff]

@isabelcosta @sidvenu FYI: I managed to fix what was missing for the creation of new tasks and it works fine now! :) I just sent a PR! Thanks for being patient with me

[mayburgos]

Solved by #231 & #521