Mentorship-android: App crashes when there is no network connection if we press send request button

Created on 25 Feb 2019 · 13Comments · Source: anitab-org/mentorship-android

Description

Describe the bug
In Members profile screen, if the network connection is not there when clicked on Send request button the app is crashing

Expected behavior
When there is no network if the user click on any member the should not show the details of the particular member and show the toast or snack bar that "there is no network connection"

To Reproduce
Steps to reproduce the behavior:

Go to members screen
Turn off the internet connection
Then click on any member and click send request
See error

Screenshots
The gif of the following bug

app crash

*Smartphone *

Device: Samsung j8
OS: 8.0.1 API 26

Update [Required]

[ ] The app should not crash if we click on send request button

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor

Coding Bug

Source

ghost

All 13 comments

@isabelcosta can I work on this thank you!

ghost on 25 Feb 2019

@isabelcosta can i work on this issue?

ak8527 on 8 Mar 2019

👍1

Yes you can @ak8527

isabelcosta on 8 Mar 2019

@ilya-maier I'm assigning this issue to you since it's approved issue and you already implemented a PR.

MariamKotob on 20 Jun 2020

@MariamKotob unassigning Ilya due to inactivity and making it availabe again.

vj-codes on 27 Jun 2020

@MariamKotob unassigning Ilya due to inactivity and making it availabe again.

Yeh, sure but also please consider closing the old PR.

MariamKotob on 27 Jun 2020

Sorry, for clicking close accidentally

MariamKotob on 27 Jun 2020

👍1

Can I work on this?

aakankshaa23 on 5 Aug 2020

Assigning you @aakankshaa23
Happy coding!

vj-codes on 5 Aug 2020

Can someone please review my PR?

aakankshaa23 on 6 Aug 2020

@aakankshaa23 can you submit a pull request? As a reviewer, we usually review pull requests instead of commits. Let me know if you need any help with it :)

isabelcosta on 6 Aug 2020

@isabelcosta Thanks for reply. I submitted a pull req today only https://github.com/anitab-org/mentorship-android/pull/747

aakankshaa23 on 6 Aug 2020

Closing this issue because it is very much similar to https://github.com/anitab-org/mentorship-android/issues/748 and it might get fixed with PR https://github.com/anitab-org/mentorship-android/pull/750