Mentorship-android: Hide Details and Tasks tabs on Current Relation screen empty state

Created on 31 Dec 2018  路  9Comments  路  Source: anitab-org/mentorship-android

Description

As a user,
I need have a correct UI,
so that I can understand the app functionalities.

Tasks are attached to a mentorship relation. So the empty state in that screen should also hide the "Details" and "Tasks" tabs

Mocks

image

As you can see in the image the empty state shows the tabs

Acceptance Criteria

Update [Required]

  • [ ] Make empty state appear in the current relation screen without showing the tabs

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

1 hour

Coding Bug

All 9 comments

Can I work on this issue @isabelcosta?

I already asked you for changes on the resend email feature are those done? @mohak1283 after that you can

@isabelcosta In this task, I have to check that if the tasks that are fetched from backend are empty then I do not have to show these two tabs? Right? I just have to show the empty state. Right?

I think that if GET /mentorship_relations/current shows that there's no relation, you won't show the tabs, so you won't show neither "Details" nor "Tasks" tab. Then you won't need to call tasks API. Makes sense? @mohak1283

Yeah, it makes sense now :+1: Can I start working on this from tomorrow? @isabelcosta

yes, of course @mohak1283

And one more thing, I was thinking in this way like, RelationPagerFragment class in which the tablayout is setup with viewpager, can I check in that class only, by using RelationViewModel class object and calling that method, If it's returning not null then only I will setup the viewpager? Is that right approach? @isabelcosta

Which is the fragment parent that is instantiated from the bottom navigation? I guess that will be the one calling the API. if you get from there that the relation does not exist, then don't build the tabs layout. Makes sense? @mohak1283

Yeah, it is RelationPagerFragment only, which is instantiated from the bottom navigation.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vaishnavi-29 picture vaishnavi-29  路  3Comments

iofall picture iofall  路  4Comments

jddeep picture jddeep  路  6Comments

devanshi7799 picture devanshi7799  路  8Comments

Dilu9218 picture Dilu9218  路  9Comments