Mentorship-android: Add validation in EditProfileFragment

Created on 22 Nov 2018  路  10Comments  路  Source: anitab-org/mentorship-android

Describe the bug
The user while editing the profile can leave any field blank. This should not be allowed. We need to add validations.

To Reproduce
Steps to reproduce the behavior:

  1. Go to EditProfileFragment.
  2. Edit name and leave it blank.
  3. Save the profile.
  4. The profile is updated.

Expected behavior
Incorrect details should not be saved.

Additional context
Add validation here

Coding Bug

All 10 comments

I would like to contribute to the project by resolving this

I tried this whenever I leave anything blank it doesn't update that in the profile neither does it show any msg like field can't be left blank

Please send a PR, someone will review the code

@207ashu
You still working on this?

Yeah, I was working on it, but couldn't resolve it, I'm also having my exams right now, so couldn't give enough time to it. Please make it available for others.

I would like to work on this issue @m-murad

Go ahead and send a PR

@m-murad I have created pull request to fix this issue. Please review it when you can.

Thank you for submitting the PR :) But be aware of "first timers only" issues. @haroldadmin

Whoops, I guess I didn't see that. I will take care now onwards.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

epicadk picture epicadk  路  5Comments

vaishnavi-29 picture vaishnavi-29  路  3Comments

annabauza picture annabauza  路  8Comments

ghost picture ghost  路  5Comments

iofall picture iofall  路  7Comments