Medusa: [Develop] JS related issues

[medariox]

TODO:

• [x] [File browser: close button is showing "close" together with the "x"](https://github.com/pymedusa/Medusa/issues/1353#issuecomment-257041472)
• [ ] [Rename page issue](https://github.com/pymedusa/Medusa/issues/1347) (Only Windows?)
• [x] [Parent Folder is not being saved, when clicked "set as default"](https://github.com/pymedusa/Medusa/issues/1424)
• [x] [Repeated checks for news? check_for_new_news loops](https://github.com/pymedusa/Medusa/issues/1348)
• [x] [Button "Checkout button" not working. Calls nothing. Nothing in logs](https://github.com/pymedusa/Medusa/issues/1353#issuecomment-257041667)
• [x] After clicking on the search icon for an episode, status never changes from "success" without reloading page
• [x] displayShow no longer has buttons to hide / show seasons:
  Tested this: 1. disable show all seasons. No buttons. 2. restarted. Buttons. 3. enabled show all seasons. No buttons. 4. disabled show all seasons. No buttons. (so I gues at this point I need to restart again) (Works after restart.)

[labrys]

• Repeated checks for github version
• After clicking on the search icon for an episode, status never changes from "success" without reloading page

[medariox]

• Repeated checks for github version

@labrys That should be fixed in latest develop version.

[fernandog]

File browser: close button is showing "close" together with the "x"

[fernandog]

Button "Checkout button" not working. Calls nothing. Nothing in logs

@ratoaq2

update: tested in master and it works.

[OmgImAlexis]

A lot of these are from updating jquery so these were expected. Will be fixed Tuesday night once I've got internet again.

[fernandog]

this issues are in master too then?! jquery update is in master.
checkout works in master

[labrys]

@OmgImAlexis your url: http://chandrewz.github.io/blog/authentication-with-vue-router

[Thraxis]

Note: These are all issues with 0.17 (Master) currently

Tables broken, No Sort or Filter on:
home
schedule
history
displayShow
etc.

displayShow no longer has buttons to hide / show seasons
Search returns a json response page on displayShow

buttons do not work on Manual Search page

[fernandog]

@pymedusa/developers if all this is happening on master we should revert jquery upgrade and hotfix.

[jxer]

i have failures all over in 2 servers, both are showing 0 shows and 1 doesn't even start after the upgrade, you need to fall back to the last commit. i am completely offline at this point

[OmgImAlexis]

Okay that doesn't sound at all like something that could have been caused by what I did since I only edited a handful of lines and updated jquery.

Do any of you have any errors showing in medusa or the js console?

[Thraxis]

vender.min.js?200:2 jQuery.Deferred exception: Cannot read property 'settings' of undefined TypeError: Cannot read property 'settings' of undefined
at Object.MEDUSA.common.init (http://unraid:9081/js/common/init.js?200:92:18)
at Object.exec (http://unraid:9081/js/core.js?200:26:35)
at HTMLDocument.init (http://unraid:9081/js/core.js?200:34:14)
at l (http://unraid:9081/js/vender.min.js?200:2:8756)
at m (http://unraid:9081/js/vender.min.js?200:2:9071) undefined

[ratoaq2]

@jxer can you check this #1364 ?

If that information couldn't help you, please reopen #1364 with information of your .db files in the application folder.

[OmgImAlexis]

@Thraxis fixed in #1365 and tooltips fixed in #1366

[p0psicles]

I don't think we should talk about reverting anymore. With all the help we're getting, we have these fixed in no time. For users on develop, just update on a daily base and keep us updated like you have been.

Most changes like the jquery have been done to remove technical debt. So they had to be done at some point.

[p0psicles]

All of the config related issues should be resolved now. I don't really have time left to check them case by case. So for the ones who reported them. Please update the issue.

[OmgImAlexis]

@p0psicles I'm guessing I accidentally removed the config page js because of that change? Lol
I might move all the pages to MEDUSA.pages.x.x to stop that happening again.

[Thraxis]

@OmgImAlexis you changed line 98 in ajax-episode-search.js from 'success' to 'done', now when a forced search is finished it never removes the spinner and sets the icon back to the search image. was that a mistaken change? https://github.com/pymedusa/Medusa/blob/d36e50ca8a36cd14d3b78146e3d484235489c955/static/js/ajax-episode-search.js#L96-L103

[fernandog]

@OmgImAlexis any ETA to fix this issues? thanks!

[bmehling]

Please note: the user @OmgImAlexis uses an avatar w/ "X O". The user @xo mentioned here is not a contributor to this project. Thx.

[OmgImAlexis]

@bmehling okay?

[OmgImAlexis]

@fernandog will try and fix these all tonight.

[OmgImAlexis]

Can someone confirm the hide/show season button is working on develop d36e50ca8a36cd14d3b78146e3d484235489c955?

[OmgImAlexis]

@fernandog so checkout works now or only in master?

[fernandog]

@omgImAlexis didnt see any fix. Still broken in develop. Try it

[OmgImAlexis]

1. Rename page issue seems to be Windows only and can be left for now as it doesn't really break anything.
2. File browser button is a issue with updating some of the libs and I'll fix that.
3. Checkout button seems to work fine in b0731a187adeb66ed37f2162f4c7b564d42ad995 but should really show a dialog or something to the user.
4. displayShow buttons "work" but currently require a restart which I guess is okay for now but I do want to fix it soon.

[duramato]

Unckecking the proper search hides the Entire remaining search settings

[OmgImAlexis]

@duramato Try the fix-proper-div branch.

[OmgImAlexis]

@medariox can you open a new issue with just the remaining things?

[fernandog]

@xo still waiting for the fix : File browser: close button is showing "close" together with the "x"

[OmgImAlexis]

Just remove the close text and it'll be fixed. Super simple.

[duramato]

Filter on History page on the Episode column doesn't work if it has the numbering likeWhite Rabbit Project - S01E10, only White Rabbit Project works. On chrome

[OmgImAlexis]

Once https://github.com/pymedusa/Medusa/pull/1807 is merged I'll fix the close issue and then can someone open a new issue for the rename page.

[OmgImAlexis]

Closing this as the last issue is fixed in the above PR, the renaming bug has it's own issue open.