Environment: 5.18-rc1 and 1.26 build 249
This ticket is created as a follow up to MM-17838
The number of reactions on the web and desktop app should be limited to 40 to match the mobile app.
Currently, additional reactions added from the webapp are breaking the mobile app UI. See attached image.
Expected: Reactions to be capped at 40. When 40 reactions are added:
Some work was started here on this issue already: https://github.com/mattermost/mattermost-webapp/pull/5222#issuecomment-705079131
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
I want to take this up.
Remove the "+:emoji: typed into the reply input field
Why is this necessary?
@esethna Could you please take a look at the questions about?
@rakhi2104 we only want to remove this functionality ("+:emoji:" in the reply input area) when there are >40 reactions. Otherwise it would allow users to add more reactions when the number of reactions should be capped.
@esethna, I didn't know the "+:emoji" shortcut. I'll try to handle this as well
Work started here to reference but anyone can feel free to take on this ticket again now: https://github.com/mattermost/mattermost-webapp/pull/5222#issuecomment-705079131
I want to take this up !
@vaibhav-stpl 馃憤 Thank you!
Here I just observed a bug on mobile app, meanwhile I was trying to reproduce the user story. So in mobile the emoji reaction icon goes away after 40 reactions, but users are still able to add reaction manually using keyboard shortcut "+:emoji" ?
Let me know if this behaviour should persist in web app too or this is a bug ?
^ @vaibhav-stpl good catch, this is a bug and should not be allowed on mobile or webapp. See this approach to how we want to solve this: https://github.com/mattermost/mattermost-webapp/pull/5222#issuecomment-606611607
ie show an error message when the post is submitted that states: "Reaction limit exceeded for this message"