We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted
issue is to modify all files in components/rhs_card
(not sub-directories included) and associated test files.
Below is a checklist of items you should be doing to migrate:
js
to ts
, jsx
to tsx
)make check-types
to display any errors.We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json
, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.
Some examples of already migrated files can be found here:
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
Grabbing this one 馃檪
Artur Zubilewicz, a student, reached out to me and mentioned that he had started working on this issue a few days ago, but he had forgotten to comment to grab it. Since he needs this work for his university studies, I want to help him, and let him take credit for implementing it. So, I'm closing my PR to allow him to grab this issue.
Artur, feel free to submit your PR 馃檪
Kudos to Abdusabri! I hoped for a chance to introduce my changes to his PR, but Abdusabri was so kind to give me a chance at my own PR :heart:
Thank you one more time! :slightly_smiling_face:
Most helpful comment
Kudos to Abdusabri! I hoped for a chance to introduce my changes to his PR, but Abdusabri was so kind to give me a chance at my own PR :heart:
Thank you one more time! :slightly_smiling_face: