Mattermost-server: Remove call to `openLhs` from SidebarChannel render method

Created on 10 Dec 2019  路  3Comments  路  Source: mattermost/mattermost-server

In the SidebarChannel component code that handles showing the tutorial tip for the Town Square and Off-Topic channels, there's a call to the openLhs action which is not allowed in React. This triggers a warning.

The openLhs call should be moved to happen after the render.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-21052

AreTechnical Debt Easy Good First Issue Help Wanted PR Exists

All 3 comments

I am taking this one

Thanks @M-ZubairAhmed :+1:

@M-ZubairAhmed You took another two help wanted tickets, but a quick reminder that you had previously also claimed this one. :) Big thanks for your help!

Was this page helpful?
0 / 5 - 0 ratings