Mattermost-server: Migrate tests from "config/unmarshal_test.go" to use testify

[mattermod]

Mattermost is migrating its server tests from using the t.Fatal method calls on their checks to use the testify toolkit. The goal of this migration is to improve the readability of the tests, making them more concise and meaningful. This Help Wanted issue is to migrate the tests in the config/unmarshal_test.go file.

The expected way to migrate this is to go to the config/unmarshal_test.go file and modify the calls to t.Fatal and the condition checks that lead to them, replacing them with calls to the the require package if a failure should stop the execution of the test, or the assert package if it shouldn't.

Example: mattermost/mattermost-server#12039

If you have questions about the ticket or you need any help, feel free to contact miguel.delacruz or jesus.espino in https://community.mattermost.com/

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-19026

[codevbus]

I'll grab this

[codevbus]

@mgdelacroix @amyblais -

For https://github.com/mattermost/mattermost-server/blob/master/config/unmarshal_test.go#L165

Do you prefer a require.True assertion on the boolean value for ok:

require.Truef(t, ok, "TeamSettings is missing from envConfig")

or would a direct call to Fail be cleaner, since we've already evaluated the bool:

require.Fail(t, "TeamSettings is missing from envConfig")

[codevbus]

Went with require.Fail

[hanzei]

Went with require.Fail

Good decision, this is much cleaner :+1: