Mattermost-server: Create a NOP Plugin for future benchmarking

Created on 26 Sep 2019  路  17Comments  路  Source: mattermost/mattermost-server

Create a plugin that implements every supported hook currently available but does nothing.

In the future, we can use this plugin as part of loadtesting to measure RPC overhead.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-13819

AreToolkit Easy Help Wanted PR Exists TecGo

Most helpful comment

Hi, I'm interested in this issue

All 17 comments

Hi, I'm interested in this issue

Thanks @SlavaBobik :+1:

Hey @SlavaBobik,

Do you have any questions?

@hanzei Hi, sorry for late response, I have a couple of questions:

  • Could you please show me example of plugin with all available hooks, which I should implement in NOP plugin?

Hey @SlavaBobik, you can find a list of all hooks at https://developers.mattermost.com/extend/plugins/server/reference/#Hooks

@SlavaBobik Did this solve your question?

Opening this up for grabs again due to inactivity.

@SlavaBobik if you're still interested working on this, let us know! Happy to answer any questions you might have.

If this is still up for grabs, I'd like to do this.

Thanks @tasdomas, it is indeed up for grabs, assigning to you

@jasonblais - great, one question first though: should this plugin be part of the mattermost-server repo or should it stand alone?

@tasdomas It should be a standalone plugin (cc @levb @hanzei if I'm incorrect)

Yes, it should be stand alone plugin

@jasonblais - I've got the start for the plugin here: https://github.com/tasdomas/mattermost-plugin-nop

If somebody could create a new repo in the mattermost namespace, I could submit this as a PR for proper review.

@tasdomas Awesome, thank you! @levb / @hanzei can you help with the repo creation, or reach out to the person who can?

PS: Given the New Year's, it might be a few days before the repo gets created @tasdomas

@tasdomas, @crspeller helped create https://github.com/mattermost/mattermost-plugin-nop to effect this review.

Note that we typically start all of our plugins from the to make things consistent. The repository above has been initialized as such, so I'd recommend fitting your propose changed into that model.

Thanks, @tasdomas!

Was this page helpful?
0 / 5 - 0 ratings