Mattermost-server: "Thumbs up" emoji does not get added to "Recently Used"

[Aninstance]

Summary

The "thumbs up" emoji - :+1: - does not get added to the 'Recently Used' field, on the web app.

Issue presents on Firefox and Google Chrome browsers (others not tested), on an Kubuntu 18.04 system (other OS's not tested).

[amyblais]

Hi @Aninstance, what Mattermost server version and desktop app version are you on?

[Aninstance]

Hi @Aninstance, what Mattermost server version and desktop app version are you on?

@amyblais Sorry, I meant to write web app, not desktop app. The server is version 5.12.1 (docker).

[amyblais]

@Aninstance I'm not able to reproduce this, would you be open to testing this on our community server to see if you experience the same issue there.

Does this only happen with the thumbs up emoji? Are all users on your server seeing this issue?

Upgrading your server to the latest might help fix the issue.

[Aninstance]

@Aninstance I'm not able to reproduce this, would you be open to testing this on our community server to see if you experience the same issue there.
Does this only happen with the thumbs up emoji? Are all users on your server seeing this issue?

@amyblais Hi, yes, no problem; I've just tested on your community server and indeed the same issue does occur there. I've only noticed the issue with the 'thumbs up' emoji. I've tested with a range of others - including 'thumbs down' - and they're all added to the 'Recently Used' list as expected.

[amyblais]

Opened a ticket here: https://mattermost.atlassian.net/browse/MM-18885.

[Aninstance]

Opened a ticket here: https://mattermost.atlassian.net/browse/MM-18885.
Thank you.

[Aninstance]

@amyblais Further to this, I note the 'thumbs up' emoji is not added to the recent_emojis array in the browser's Local Storage, so it's an issue with the _adding_ rather than subsequent read. Being that the thumbs up emoji is denoted in the array by +1, I wonder if this could be some kind of code type issue (i.e. the 1 is typed as an integer rather than a string at the point at which it's supposed to be added to the array). Only speculation, as haven't yet had chance to dig into the code myself.

However, being that you're unable to reproduce would suggest there's some kind of local environmental factor that causes the issue to manifest, which I guess could mitigate against above.

[lieut-data]

Thanks, @Aninstance! I've got a PR up to address this on webapp: https://github.com/mattermost/mattermost-webapp/pull/3798.

[amyblais]

Closing as this is fixed for v5.16 release which will be released on October 16th,