Mattermost-server: Remove deprecated lifecycle methods from settings screens

Created on 24 Sep 2019  路  8Comments  路  Source: mattermost/mattermost-server

The following React lifecycle methods have been deprecated by React and will start to be removed starting in React 17:

  • componentWillMount
  • componentWillReceiveProps
  • componentWillUpdate

The React team has published a guide discussing the changes and how to migrate to the new lifecycle methods here: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

As part of a campaign to remove these methods from https://github.com/mattermost/mattermost-mobile, these methods should be replaced in the following files:

  • app/screens/settings/notification_settings_mobile/notification_settings_mobile.android.js
  • app/screens/settings/notification_settings/notification_settings.js
  • app/screens/settings/notification_settings_email/notification_settings_email_base.js
  • app/components/radio_button/radio_button_group.js

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-18765

AreTechnical Debt Medium Help Wanted PR Exists TecReact Native

All 8 comments

I have a PR for this issue

Awesome, Thanks @GunnlaugurCalvi!

Ticket was re-opened

Can I start working on this?

@RominHalltari absolutely, go ahead

Making this available for the public again. Please let me know if you still want to work on it @RominHalltari

I'm already working on #12353. It make sense to me to take this on as well.

@migbot I was away for a while and finally wrapping up 12353. I still plan on working on this.

Was this page helpful?
0 / 5 - 0 ratings