Mattermost-server: Help code review BigBlueButton plugin repository

[jasonblais]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Plugins Guide.

---

Blindside Networks has contributed a great open source web conferencing BigBlueButton for Mattermost.

The source and documentation are available here: https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton

We're looking for help from our communities to code review the plugin and offer suggestions for improvements and fixes. Bonus for submitting a PR for those fixes!

[ffdixon]

I'm the Product Manager for BigBlueButton.

We'd be interested in working with any developer familiar with Mattermost plugins that would like to review, improve, or extend the BigBlueButton integration with Mattermost.

If you are running Mattermost behind a corporate firewall and you are looking for a web conferencing solution that also works behind your firewall (i.e. you can run it locally like Mattermost), definitely check out BigBlueButton.

[harshilsharma2]

@jasonblais I can review the server part of the plugin sometime this week.

[jasonblais]

Great, thank you @harshilsharma63! That would be great 👍

[ffdixon]

Ditto!

[harshilsharma2]

Any ideas on how I can add review comments? We need to diff the whole codebase.

[harshilsharma2]

If the repository owner can create an empty branch and a PR from master into this empty branch, I and other reviewers can add the review comments over there.

[jasonblais]

@harshilsharma63 An option is to do the following:

1. git checkout --orphan dummy-branch
2. commit the basic files that aren't going to be code reviewed
3. push to upstream/dummy-branch
4. commit everything we want to review to a new dummy-master branch
5. make a PR for dummy-master -> dummy-branch
6. comment on that PR

Also submitted a PR to document these in the dev docs https://github.com/mattermost/mattermost-developer-documentation/pull/304

[harshilsharma2]

@jasonblais yes, exactly. But this needs to be done on the original repo. Pushing the dummy branch would need write access.

Or I can do all that in my fork, but I'm not sure how convenient if will be for other folks. Thoughts?

[jasonblais]

Good point, wondering if someone on your team @ffdixon would be open to helping with steps 1 - 5 above (pushing a dummy branch and opening a PR for @harshilsharma63 to review)?

[ffdixon]

@harshilsharma63 we've made you a collaborator on https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/ -- let us know if that gets you going.

[harshilsharma2]

@ffdixon that worked. Thanks!

Code review PR is over at https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/pull/41

[harshilsharma2]

@jasonblais I had to make a minor change to the steps you mentioned.

1. take a backup of project dir

2. create dummy master branch with no code -

   git checkout --orphan dummy-master #create the dummy master branch
   git rm -rf . #remove everything from this branch
   git push origin dummy-master
   

3. Create dummy-feature branch from dummy-master -

   git checkout -b dummy-feature
   # copy. everything from backup except the .git dir
   git add .
   git commit -m "Full checkin"
   git push origin dummy-feature
   

4. Create a PR from dummy-feature -> dummy-master

[jasonblais]

Thanks! Updated the doc PR accordingly: https://github.com/mattermost/mattermost-developer-documentation/pull/304

[harshilsharma2]

Updated review PR created here - https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/pull/44/

[harshilsharma2]

@jasonblais @ffdixon I've added review comments for server component of the plugin.

[jasonblais]

Great, thank you! I'll let Fred chime in on the review comments as well 👍

[jasonblais]

Thanks @harshilsharma63 for the help :) Closing this issue

An updated version of the plugin is available at https://github.com/blindsidenetworks/mattermost-plugin-bigbluebutton/releases