Mattermost-server: Remove the hard-coded post menu divider from Jira, and add it in the webapp for all plugins

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Remove the hard-coded post menu divider from Jira, and add it in the webapp for all plugins.

Then, anytime a new plugin item get added, the divider automatically gets added as well. See an example of the divider for the Jira plugin

Note that the css was already added to the webapp with https://github.com/mattermost/mattermost-webapp/pull/2821

Hence, the only change is to
1) take the HTML from the Jira plugin [here|https://github.com/mattermost/mattermost-plugin-jira/blob/jira2/webapp/src/components/post_menu_actions/create_issue/create_issue.jsx]

                <li
                    className='MenuItem__divider'
                    role='menuitem'
                />

2) and add it into the webapp with the proper markup logic.

[Azero123]

Can I take this one?

[lieut-data]

Go for it, @Azero123!

[hanzei]

Hey @Azero123,

How is your work going? Do you have questions?

[Azero123]

hey @hanzei, sorry i have been working on a different issue and have been pretty slammed this week. but i do have a question, do we have an existing jira server i could connect my mattermost dev server to? or do i need to make a new one?

[hanzei]

@levb Do we have a jira server that @Azero123 can use?

[lieut-data]

@hanzei, @Azero123 -- I don't think we have a JIRA server available, but I suspect we can safely iterate on this one without. It should be possible to verify the divider being added for new plugins, and a spot check on the JIRA plugin changes should confirm its removal.

Hopefully we'll have a better story for plugin testing like this in the near future.

[hanzei]

@Azero123 Does the answer above solve your problem?

[lieut-data]

Marking this one as available again due to inactivity.

[janvt]

Think I figured this one out, will submit a PR later.

One clarification, the divider should appear once above all plugin menu items? Or once per plugin (if there are multiple plugins)?

[lieut-data]

@janvt, I believe the intent is to add it once per plugin. @aaronrothschild, thoughts?

[aaronrothschild]

I'm not sure if the original intent was to differentiate from "plugins" and "built-in functions". I don't think we need the divider between each plugin. I think it should show up once at the top of the list of plugins 1/5.
However, if @asaadmahmood has differing thoughts I will defer to him.

[asaadmahmood]

The intent was to add a divider between default actions, and actions that were further added by plugins, not necessarily between plugins.

[janvt]

Sounds good. Once before all plugins is relatively easy, once before each plugin would require some reworking of the plugin system, as far as I can see with my React skills. :)

[adityayavagal]

Hello can I grab this one? If yes please I need someone for help as I'm new open source contribution

[hanzei]

@adityayavagal Sorry, this issue isn't available. @janvt is currently working on it. You can find all available tickets with this query: https://github.com/mattermost/mattermost-server/issues?q=is%3Aopen+label%3A%22Up+For+Grabs%22+sort%3Aupdated-desc

[saturninoabril]

PR has been merged. Thanks @janvt!