Mattermost-server: Migrate "Session.Remove" to Sync by default

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Mattermost is migrating its Store layer to be sync by default, and only use Async when needed and we're looking for contributors to help with that effort. This Help Wanted issue is to migrate the Remove in the Session store.

The expected way to implement it is, go to the Session store implementation in the store/sqlstore/ directory, modify the method Remove to return directly an object from the model module, and a *model.AppError (removing the store.Do wrapper). After that, you must modify the interface defined in store/store.go to match with the changes. Then, you should execute make store-mocks to rebuild the mocks with the new interface. And finally, modify the rest of the code (tests included) to use the new interface of the function properly.

Example: mattermost/mattermost-server#10613

[piperRyan]

I would like try to resolve this issue.

[hanzei]

Thanks for working on this @piperRyan! Let me know if you have any questions.

[hanzei]

Hey @piperRyan,

How are you doing with this ticket? Do you have questions?

[piperRyan]

@hanzei Sorry, ended being at the lake longer than I thought. I will get this figured out today.

[piperRyan]

@hanzei I do have a few question. Would it be easier to discuss them on the developers channel?

[hanzei]

Yes. If you post them in the ~Developers Channel, everyone can help answering them.