Mattermost-server: Add confirmation dialog when posting a message with `at-channel`

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

---

Notes: Jira ticket

Currently the webapp displays a confirmation dialog when posting a message with an at-channel at-all mention in a channel with over 5 members.

We need to add this confirmation dialog to the mobile app.

Note this dialog is enabled/disabled by the System Console config "Show @channel and @all confirmation dialog" (EnableConfirmNotificationsToChannel)

[courtneypattison]

I'll try this one :) I've looked into it a little bit and am wondering if there are any shared utils between mattermost-webapp and mattermost-mobile. Specifically, I would like to use containsAtChannel() from mattermost-webapp post_utils. Should I just copy this function and its dependencies over?

[jasonblais]

Thank you @courtneypattison!

@hmhealey @enahum would you know the answer to Courtney's question?

[enahum]

You could move that function to mattermost-redux and then use the same reference in both the webapp and mobile

[courtneypattison]

@enahum Thank you! I guess it's time to learn redux :) Also, I forgot to ask, are there any dummy users I can add to a test channel in community.mattermost.com to make it a channel with more than 5 users?

[jasonblais]

are there any dummy users I can add to a test channel in community.mattermost.com to make it a channel with more than 5 users?

Not on community.mattermost.com, but we have a public test instance that has several test accounts, would you be open to creating an account there? I've attached a screenshot of some of the test users and an invite link for the test instance is here: https://mysql.test.mattermost.com/signup_user_complete/?id=353fff15eeccb99b54c30158c43e4ee6

[courtneypattison]

@jasonblais That is perfect! Thank you!

[hmhealey]

I guess it's time to learn redux

It's good to know, but you might not need it for just this. Despite the name of that library, it contains a bunch of shared code alongside our Redux stuff.

[hanzei]

Hey @courtneypattison,

How are you doing with this ticket? Did the test server work for you? Do you have further questions?

[courtneypattison]

@hanzei Sorry! I've been busy and haven't made much progress on this ticket. I should have time next week but feel free to put it up for grabs in case someone else wants to give it a shot :)

[hanzei]

Hey @courtneypattison, Thanks for the heads up! I've made this ticket available for the public again, but it would be great, if you work on this when you have the time.

[hahmadia]

I'll take a look into this.
Thanks :)

[hanzei]

Awesome, thanks @hahmadia :tada:

[hahmadia]

@hanzei Completed. Just waiting for a code review and help with a problem I encountered.
Thanks :)