Mattermost-server: Include the Theme property on UserTeamMemberships in Bulk Export

Created on 3 Oct 2018  路  22Comments  路  Source: mattermost/mattermost-server

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.


Notes: Jira ticket

This ticket forms part of the Bulk Export campaign. The bulk export feature (implementation in app/export.go and app/export_converters.go is intended to provide a CLI-based means to export the data in a Mattermost instance to a JSONL file. It is the inverse of the much more well developed Bulk Import feature, so a data file exported from the Bulk Export feature should be importable with the Bulk Import feature.

This ticket is to populate the Theme selection of each user at the per-team level. The field to be populated is the Theme field on the UserTeamImportData object in app/import_types.go. You can see how it is imported in the ImportUserTeams() function in app/import_functions.go.

AreBulk ImporExport Easy Good First Issue Help Wanted PR Exists TecGo

Most helpful comment

Resuming work on this. Will hopefully have a PR today.

All 22 comments

I'm interested in tackling this issue.

Hi @lannonbr , that's great. If you need any help at all with getting started, or want to discuss ideas about the implementation, do feel free to ask here or on the Mattermost server linked at the start of this ticket. You can find me there with the name @george.

@lannonbr Are you still working on this issue? If not I would love to take up this.

@waseem18 I've been working on some other stuff and I haven't gotten around to doing this, so feel free to work on it.

Thanks for the prompt reply @lannonbr
I'll start looking into this.

@grundleborg I was wondering if #9538 and this issue are related.

I see theme selection included as a part of preferences. Wanted to confirm with you before starting to work on this.

Thanks

This is for the per-team theme setting, where users can have a different theme for each team. The other ticket should just be exporting the user's default (system-wide) theme preference.

Update : I've started working on this issue and will have a PR in a day or two.

@waseem18 How is your implementation doing? Can we help with something?

Trying to import bulk data with user's theme code. Got error: BulkImport: JSON decode of line failed., json: cannot unmarshal array into Go struct field UserTeamImportData.theme of type string. It looks like array is not added to Golang script.

FYI @grundleborg & @hanzei on above note from @hollabigj

@hollabigj Could you please open a new issue for this with step to reproduce?

Resuming work on this. Will hopefully have a PR today.

Hey @waseem18,

I want to gently remind you about this ticket. I know are currently working on the Jenkins Plugin, but I want to check if you are still planing to work on this ticket.

@hanzei At this point I don't think I'll be able to work on this ticket anytime soon.
Once Jenkins plugin gets published, may be then I can start contributing to the MM issues.

Hey @waseem18,

Thanks for the head up. Let's make this available for the public again. And if you still want to pick this up after you are done with the jenkins plugin, just tell me!

hi. i would like to work on this.

Thanks for taking a shot @renilJoseph :+1:

Just want to check if you have any questions @renilJoseph so far.

Making this one available for the public again due to inactivity.

I麓ll try to implement this one.

Thanks @noxer :+1:

Was this page helpful?
0 / 5 - 0 ratings