Mattermost-server: Don't send notifications or mark channel unread if a post is made to a comment thread that's open in right hand sidebar, and Mattermost is in focus

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.

---

Notes: Jira ticket

Don't send desktop or push notifications and don't mark channel unread if a post is made to a comment thread that's open in right hand sidebar, and Mattermost is in focus.

Example:
1) comment thread for channel_A is open in right-hand sidebar,
2) channel_B is open on the center pane
3) Mattermost is in focus
4) If someone posts a message on the comment thread for channel_A that is open in the right-hand side, do not send desktop and push notifications for that post, and do not bold channel_A in the left-hand sidebar.

Start of a PR here that was since closed: mattermost#6461

[sudheerDev]

@esethna I will work on this.

[jasonblais]

Yay!! Thanks @sudheerDev

[sudheerDev]

@jasonblais i forgot about this. Will check this over weekend. Into some performance PR's

[krjn]

Working on this.

[hanzei]

Thanks @krjn :+1:

[krjn]

PR here: https://github.com/mattermost/mattermost-webapp/pull/3009

[hanzei]

Wow, that was fast :rocket:

[krjn]

Ah, I started it before, and forgot to claim the issue after I was sure on a way forward.

One thing I'd have liked to do is clear the unread status of the channel in the following case:

MM on channel #A, unfocused, with thread from #B on the RHS
Message received on the thread on #B
Unread status is applied on #B, because MM was unfocused
Now, when MM receives focus, on #A, but with the thread on #B on the RHS, _if the only_ messages sent to #B were from the thread: then clear the unread

But I didn't find a quick and elegant way of doing that in short time, so I didn't extend the scope.

[hanzei]

@esethna :point_up: