Mattermost-server: [Help Wanted] [PLT-7567] Team Icons

[esethna]

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide, specifically for machine setup and for developer workflow.

---

Notes: Jira ticket

See corresponding ticket for mobile: https://mattermost.atlassian.net/browse/RN-418

Team Icons will appear in the team sidebar within the border of the existing team icons:

• The mention counter on the team sidebar should have a 1px stroke

Add a Team Icon setting to the Team Settings modal below the Team Description setting:

• Collapsed text when image is set: "Image last updated MMM DD, YYYY"
• Collapsed text when no image is set: "Click Edit to upload an image."

When editing the Team Icon the setting expands:

• If no image has been uploaded, do not show an image preview until an image is selected:

• If an image has been previously uploaded or a new image is selected, show the preview similar to the Profile Picture setting in Account Settings

Buttons (Same as Profile Picture setting in Account Settings):

• "Select": Opens the file selector to choose a team icon. Once selected, the image preview is rendered in the modal.
• "Save": Saves the new Team Icon after selecting a new image. Button is disabled unless an image is selected using the "Select" button.
• "Cancel": Collapses the "Team Icon" setting.

[santos22]

I would like to take this one 👍

[esethna]

Awesome @santos22!

[esethna]

Hey @santos22 hope this is going well, please let me know if you have any questions about the design!

[santos22]

Hi @esethna,

Thanks for checking in! I'm making progress on the Go portion of this issue and will soon start working on the ReactJS portion 👍

[santos22]

Hi @esethna,

Does this issue also require changes to Redux?

[esethna]

Hey @santos22, adding @jwilander to help answer that.

[jwilander]

Yes, you'll need to add client driver functions, actions and possibly a reducer to mattermost-redux

[esethna]

Hey @santos22, hope all is well! Just letting you know that we have the cut off date for merging major features for the 4.5 release coming up on November 29th. Anything we can help with on this ticket?

[santos22]

Hi @esethna,

Thanks for checking in. Still working on the Redux portion to this issue - shooting for next month's release 😄

[santos22]

Hi @esethna,

I'm afraid I won't be able to complete this issue. Don't want to hold up this feature because it seems pretty important so someone else can take a look at it! I will make sure to provide more frequent updates on any other issues I work on 👍

[jasonblais]

Thanks @santos22 for the heads up! I'll add the Up for Grabs label back

[chumbalum]

Hello,

I'm all new to Mattermost developing but I would like to contribute to this issue. I already started developing and now I think I'm confident enough to say that I could get the job done.

There is plenty of code concerning the profile-image, which I can orientate myself on. Since I've never done go before, I maybe need some support at some points.

[jasonblais]

@chumbalum That's great! Thank you so much for your interest.

As mentioned in the ticket description, you can join our "Developers" community channel, for technical advice and questions. We're more than happy to help.

@santos22 Curious if you had a fork or a branch where you had started working on it, in case it was useful for @chumbalum to get started.

[santos22]

Welcome @chumbalum!

I do have some code that I worked on locally that I can push shortly. In the meantime, you can start by looking at API calls for user profile images here and the test files:
https://github.com/mattermost/mattermost-server/blob/master/api4/user.go
https://github.com/mattermost/mattermost-server/blob/master/api4/user_test.go

[chumbalum]

Thanks for your support. I will take a further look into the existing code and contribution procedure the next days and will deep dive into it on the weekend.

[chumbalum]

Hi,

just a quick update. Apart from minor ui logic, I'm almost done. Setting team icon works, tested with seperate users concerning change notification

I'm going to make some further tests, put everything in a clean state the next days and would open a pull request. Have to take a look into that, since I've never done that before.

[jasonblais]

Huge thanks @chumbalum for helping with this feature! It's now merged and scheduled for v4.9 release on April 16th