Materialdesigninxamltoolkit: Styles for PackIcon is missing from the wiki page "ControlStyleList"

Created on 20 Jun 2019  路  4Comments  路  Source: MaterialDesignInXAML/MaterialDesignInXamlToolkit

bug good first issue up-for-grabs

All 4 comments

For anyone who wants to work on this. The powershell that is used to generate that wiki page is located in /Scripts/GenerateThemesWikiMarkdown.ps1. No need to update the wiki directly as there is not an Azure pipeline that will take care of running the script and deploying any changes.

@Keboo There is no default Style defined for PackIcon under Themes folder. Thus, the PS1 script is not picking and adding the Style list in Wiki

I could see Style for PackIcon were created inline in MaterialDesignTheme.ListBox.xaml, MaterialDesignTheme.Menu.xaml and MaterialDesignTheme.ToolBar.xaml.

Do we need to create default Style for PackIcon under Generic.xaml?

Something like,

<Style TargetType="{x:Type wpf:PackIcon}" >
    <Setter Property="Width" Value="22" />
    <Setter Property="Height" Value="22" />
</Style>

Your thoughts?

@dhilmathy there is an existing style for the PackIcon in the Generic.xaml. So you shouldn't need to add one. I did not spend much time trying to figure out why it is being excluded from the output.

@Keboo I see that now. Thanks for pointing that; I can check the script.

Was this page helpful?
0 / 5 - 0 ratings