Material-ui: [Tooltip] Outdated TooltipClassKey type

Created on 27 Nov 2019  路  5Comments  路  Source: mui-org/material-ui

https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Tooltip/Tooltip.d.ts#L49 should also include the arrow key. A problem if you are using TS.

Tooltip good first issue typescript

Most helpful comment

@dufia Thanks for the report.

diff --git a/packages/material-ui/src/Tooltip/Tooltip.d.ts b/packages/material-ui/src/Tooltip/Tooltip.d.ts
index 4347a73c2..4241b22bb 100644
--- a/packages/material-ui/src/Tooltip/Tooltip.d.ts
+++ b/packages/material-ui/src/Tooltip/Tooltip.d.ts
@@ -42,6 +42,8 @@ export type TooltipClassKey =
   | 'popper'
   | 'popperInteractive'
   | 'tooltip'
+  | 'tooltipArrow'
+  | 'arrow'
   | 'touch'
   | 'tooltipPlacementLeft'
   | 'tooltipPlacementRight'

All 5 comments

@dufia Thanks for the report.

diff --git a/packages/material-ui/src/Tooltip/Tooltip.d.ts b/packages/material-ui/src/Tooltip/Tooltip.d.ts
index 4347a73c2..4241b22bb 100644
--- a/packages/material-ui/src/Tooltip/Tooltip.d.ts
+++ b/packages/material-ui/src/Tooltip/Tooltip.d.ts
@@ -42,6 +42,8 @@ export type TooltipClassKey =
   | 'popper'
   | 'popperInteractive'
   | 'tooltip'
+  | 'tooltipArrow'
+  | 'arrow'
   | 'touch'
   | 'tooltipPlacementLeft'
   | 'tooltipPlacementRight'

@dufia Do you want to work on a pull request?

@oliviertassinari I'd love to do it, please assign me

Hey, I've noticed 4.7.1 was released and it included this fix. But somehow, it didn't make it into the released code. When I check my node_modules for @material-ui/core/Tooltip/Tooltip.d.ts, type TooltipClassKey remains unchanged. Any ideas why?

I definitely have 4.7.1 installed.

@dufia #18645 was not included in 4.7.1. It was released before the PR was merged: https://github.com/mui-org/material-ui/compare/v4.7.1...master

Was this page helpful?
0 / 5 - 0 ratings