Material-ui: [Core] Replace string refs with callback refs
React docs says the following about string refs:
React also supports using a string (instead of a callback) as a ref prop on any component, although this approach is mostly legacy at this point.
There are also React issues that indicate string refs will eventually be deprecated. We should consider moving to callback refs when we're able to do so.
discussion
newoga
👍3
All 3 comments
Yeah I agree with you :+1: :+1:
alitaheri
on 23 Feb 2016
This issue is beeing addressed in the next branch. To have more context on why it's bad, you can have a look at https://news.ycombinator.com/edit?id=12093234
We should make sure that the corresponding eslint rule is enforced.
oliviertassinari
on 23 Jul 2016
👍3
As pointed out by @gulderov, the no-string-refs eslint rule is now enforced. We can close the issue.
oliviertassinari
on 11 May 2017
Was this page helpful?
0 / 5 - 0 ratings
Related issues
amcasey
路
70Comments
HZooly
路
63Comments
sjstebbins
路
71Comments
Bessonov
路
93Comments
aranw
路
95Comments
Most helpful comment
This issue is beeing addressed in the
nextbranch. To have more context on why it's bad, you can have a look at https://news.ycombinator.com/edit?id=12093234We should make sure that the corresponding eslint rule is enforced.