Material-ui: eslint-plugin-react is presented inside package.json but not used in .eslintrc.js

Created on 3 Dec 2018  路  6Comments  路  Source: mui-org/material-ui

This is not an issue, I'm just trying to understand the codebase. I don't think it would be approriate to post this question on StackOverflow or Twitter.
I saw the eslint-plugin-react inside package.json, however it is not used inside .eslintrc.js? Is it intentional? If so, why's that?
Thank you and sorry for an off-topic question

question

Most helpful comment

@oliviertassinari Theoretically it should work. I will give it even a closer look and make a pull request if it actually works this weekend

All 6 comments

Hi @oliviertassinari thanks for the clarification! One last question regarding this issue, why did you declare jsx-a11y and import as plugins? Hasn't Airbnb config already declared these?

@WebDeg-Brian We haven't changed the eslint configuration for a long time. It can probably be simplified now. Did you have a closer look?

@oliviertassinari I cloned the project and remove those 2 plugins and it still works. Btw I looked into the component files and saw everything sorted in alphabetically order (object destructuring, default props, prop-types, etc.) I already know how to sort prop-types but not the other two. Is there a plugin for it?

@WebDeg-Brian I sort the properties with Sublime Text. Do you want to submit a pull request removing the two plugins as already provided by Airbnb? When you say it works, does it mean it still reporting failing cases?

@oliviertassinari Theoretically it should work. I will give it even a closer look and make a pull request if it actually works this weekend

Was this page helpful?
0 / 5 - 0 ratings