Material-ui: onTouchTap doesn't work with React 15.6.0

Created on 14 Jun 2017 · 8Comments · Source: mui-org/material-ui

The onTouchTap from Buttons isn't working with React 15.6.0 https://facebook.github.io/react/warnings/unknown-prop.html
I think it's finally time to move to the standard onClick and remove tap event plugin

bug 🐛

Source

bogdansoare

😕1

Most helpful comment

think it's finally time to move to the standard onClick and remove tap event plugin

That's what we did on the next branch.

oliviertassinari on 14 Jun 2017

👍6

All 8 comments

think it's finally time to move to the standard onClick and remove tap event plugin

That's what we did on the next branch.

oliviertassinari on 14 Jun 2017

👍6

any idea of the next release date that includes that change ? thanks in advance.

lantenac on 15 Jun 2017

That might need to be fixed at the react-tap-event-plugin level. I'm not sure we can do anything here.

oliviertassinari on 15 Jun 2017

Hi, just to confirm: is there absolutely no way to use material-ui with recent versions of react?

I'm trying it out for the first time and I tried setting up react-tap-event-plugin as instructed in the README, but I'm still getting the warning in my console about unknown props, and the IconMenu that I put in my app isn't responding to clicks.

radix on 21 Jun 2017

I filed a ticket on react-tap-event-plugin to see if there's a workaround there: https://github.com/zilverline/react-tap-event-plugin/issues/103

radix on 21 Jun 2017

I'm considering the option to move away from onTouchTap for onClick in the v0.x releases in order to fix that issue. That's going to be an important breaking change. Hopefully, the upgrade path should be pretty easy. Also, I haven't seen any limitation with onClick yet.

oliviertassinari on 22 Jun 2017

🎉1

I have been setting up a create-react-app project (that use 15.6.1 internally). I had no issue, the touch callbacks are still working. I'm assuming it's another limitation of react-tap-event-plugin. If it's a blocker for you, consider using the v1-alpha branch. We are even supporting the 16.0.0-alpha.13 release of React on that branch.

oliviertassinari on 11 Jul 2017

I have been setting up a create-react-app project (that use 15.6.1 internally). I had no issue, the touch callbacks are still working. I'm assuming it's another limitation of react-tap-event-plugin. If it's a blocker for you, consider using the v1-alpha branch. We are even supporting the 16.0.0-alpha.13 release of React on that branch.

Can you elaborate a little bit here @oliviertassinari ?
How should I go about doing that upgrade in order to fix this?

Thanks!