Material-ui: [Select] Port component

Created on 22 Jul 2016  路  4Comments  路  Source: mui-org/material-ui

  • [ ] Component
  • [ ] Tests (at least unit tests)
  • [ ] Docs
  • [ ] Demo

Previous attempt:

  • #6301
  • #6608

Most helpful comment

I would love to get porting of the SelectField component going again. I checked out the referenced issues, mainly #6608 however to be honest I'm unsure what the ultimate conclusion of #6608 actually was.

So far I started rebasing the branch from #6608 onto the current v1-alpha branch, see https://github.com/callemall/material-ui/compare/v1-alpha...ctavan:v1-select-field

However in the current form the examples yield endless re-render loops so I'll dig further into it.

I'm happy to continue working on this and bringing this into a mergeable shape, however I would need some guidance from you as to what the feature set of the SelectField should actually be, in particular in comparison to Autocomplete functionality, which has been discussed in #6608 but I don't see a final conclusion on this.

So any input with respect to what scope a SelectField component in Material-UI should have would be highly appreciated and I'm happy to do further work on this.

All 4 comments

I would love to get porting of the SelectField component going again. I checked out the referenced issues, mainly #6608 however to be honest I'm unsure what the ultimate conclusion of #6608 actually was.

So far I started rebasing the branch from #6608 onto the current v1-alpha branch, see https://github.com/callemall/material-ui/compare/v1-alpha...ctavan:v1-select-field

However in the current form the examples yield endless re-render loops so I'll dig further into it.

I'm happy to continue working on this and bringing this into a mergeable shape, however I would need some guidance from you as to what the feature set of the SelectField should actually be, in particular in comparison to Autocomplete functionality, which has been discussed in #6608 but I don't see a final conclusion on this.

So any input with respect to what scope a SelectField component in Material-UI should have would be highly appreciated and I'm happy to do further work on this.

@ctavan I believe we have decided to leave Autocomplete as a sample only, providing underlying components, but not to provide such a high level component ourselves.

See https://github.com/callemall/material-ui/pull/7477

Makes a lot of sense! I will try to bring the SelectField into a reasonable state over the next few days but I'll try to restrict it as much as possible to be really more like a html <select> replacement and keep all more complex functionality out of scope.

See https://github.com/callemall/material-ui/pull/7458

Closing as duplicate of #5716

Was this page helpful?
0 / 5 - 0 ratings

Related issues

finaiized picture finaiized  路  3Comments

newoga picture newoga  路  3Comments

mattmiddlesworth picture mattmiddlesworth  路  3Comments

reflog picture reflog  路  3Comments

mb-copart picture mb-copart  路  3Comments