Material-ui: [Core] Ensure React v15 compatibility

[nathanmarks]

Hey @callemall/material-ui ,

We should make sure we support React v15 for the 0.15.0 release of mui. Has anyone had the chance yet to check out the lib with the release candidate?

If anyone finds an issue that needs fixing, please add it here!

stuff that needs doing

• [ ] Some random v15 issue we haven't caught yet

[alitaheri]

Yes! let there be mui.minor === react.major :+1: :+1:

[Mythra]

Yea I seemed to run into some issues with the drop down menu specifically in my code.

Issue #3634

Not mentioned in that issue that should probably be is the fact all touch events seem to not be firing (not just the dropdown)

[alitaheri]

Hmmm I think that's an issue with the touch-tap-plugin.

[bushmango]

I'm also having issues with tabs and icon menus -- the clicks do the ripple effect but don't trigger any events.

[nathanmarks]

https://facebook.github.io/react/blog/2016/04/07/react-v15.html

[kokarn]

@bushmango @alitaheri @LordLambda There's some issues with React 15 and the tap event thing.
Fixed in repo and soon published to npm https://github.com/zilverline/react-tap-event-plugin/issues/66

[kunkun12]

SelectField not working with React 15

[ffxsam]

Hmmm I think that's an issue with the touch-tap-plugin.

react-tap-event-plugin is no longer needed, apparently (I just found this out). Mobile Safari and Chrome made it so if your web app is set to not scale/zoom, the 350ms tap delay is removed. Finally!

[nathanmarks]

@ffxsam it's going to be a little while before a reasonable amount mobile phone users (esp android) are on the latest version

[Connorelsea]

A direct copied toolbar example is not working for me on React v15.0.1

Code copied directly from the toolbar example (http://www.material-ui.com/#/components/toolbar) looks like this: http://i.imgur.com/ToG2LKZ.jpg
(and none of the buttons or actions work)

See this maybe: https://github.com/facebook/react/issues/6221

I'm fairly new to Material UI and I'm not sure how to fix.

[nathanmarks]

@Connorelsea same reason as discussed above

[nathanmarks]

@ffxsam Actually I just realised that chrome has had it on android since version 32.

Maybe we really can get rid of it.... https://github.com/gpbl/react-day-picker/issues/153

[ShMcK]

A solution for the touch tap problem:

Possible solution:

Use the latest version of react-tap-event-plugin in your package.json. Unfortunately there is not yet a new release.

"react-tap-event-plugin": "git+https://github.com/zilverline/react-tap-event-plugin.git"

[nathanmarks]

It has been released now: https://github.com/zilverline/react-tap-event-plugin/issues/66#issuecomment-208385262

https://www.npmjs.com/package/react-tap-event-plugin

@ShMcK using git urls in package.json is not a good practice for open source libraries, so we would be very unlikely to ever merge a fix like that

[witnessmenow]

I'm having issues with tabs, I'm new to mui so I'm not sure if I am doing something wrong or is it related to this.

I've taken a direct copy of the tab examples from the simple example here

I've updated to release 1.0.0 of react-tap-event-plugin in my package.json

The tabs display fine, they get coloured as if I click them (the grey shadow thing, the active tab indicator does not change) but It does not change the content

Any suggestions?

[oliviertassinari]

https://github.com/callemall/material-ui/pull/3941 was just merged. Thanks @nathanmarks.
We will release it in the upcoming beta. I'm closing this issue.

[DanielHoffmann]

@oliviertassinari do you have an ETA to publish to NPM this fix? My project is depending on Material-ui and this. I will downgrade react back to an older version if you say it might take some time. Thanks!

[oliviertassinari]

@DanielHoffmann It has been on NPM for a long time now (1 year).

[DanielHoffmann]

@oliviertassinari Hm, that is weird, I thought my material-ui stopped working after I updated to the newest version of react, I thought the cause was this issue. I am using version 2.0.1 of this plugin and React 15.5.4
I just realized that the last post was on april 2016, not 2017. Sorry my bad, I will try to figure out what is the problem here.