Material-theme-jetbrains: Material oceanic list background and secondary color issue

Created on 7 May 2021  路  17Comments  路  Source: ChrisRM/material-theme-jetbrains

Material oceanic list background and secondary color issue, makes suggestion very difficult to see kindly check the difference between the 2 images, the first for the latest version (paid version) the other which is much more better for an older version. Thanks for your efforts
image
Screenshot 2021-04-10 225347

enhancement fixed

All 17 comments

I also noticed that something has changed! Glad to see I wasn't seeing things.

Can we have a quick fix for that or shall we wait for the next version ?
Thanks.

I don't think I'll do another release for now, maybe on Sunday if I find the issue.

Just found out that the "unfocused selection" has been deprecated at some point. That also explains the similar issue in the Material UI Lite.

I'll have no choice but to change the color of the "focused selection".

This might take a while, as I need to adapt to all themes.

image
image

Which option is better?

I think the first option has more contrast which makes it more readable, what do you think ?

What about changing the list background color to be the same as the editor background color as in the below image
Screenshot 2021-05-11 041436

That was my first options but because we have no shadows it would be blending with the background which is less than ideal (it's already happening with the menus and I hate it)

But yeah everyone prefers the first option (it's what's implemented in vscode as well), now I need to see if it renders well in all themes

Thanks mallowigi, is there will be any update to install for this issue ?

Hello Mallowigi, kindly check the difference between the two screen, after installing the new updates, suggestion on typing has this highlight color

image

but on clicking the below selection the highlight color changes

image

the second one is much more better and readable

the same for file search as in the pic below, has a different highlight color

image

the same for file search as in the pic below, has a different highlight color

image

I won't change that. The lines are readable enough, it's not like the completion popup.

yes, just wanted to maintain consistency between the whole app

I'm starting to regret my decision... I think I'll restore the old behaviour but introduce a setting to choose a specific style

Why do you regret the changes, it is much more better specially the drop down list except what was mentioned about the first selection

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sheinfeld picture sheinfeld  路  4Comments

ovr picture ovr  路  3Comments

mallowigi picture mallowigi  路  3Comments

dg00GT00 picture dg00GT00  路  3Comments

timrspratt picture timrspratt  路  3Comments