Material-dialogs: Re-think max width

[guger]

Library Version:

2.1.0

Affected Device(s):

Google Pixel 2 XL with Android 9.0

Describe the Bug:

The dialog width changed (got smaller) when upgrading from 2.0.3 to 2.1.0.

Does this have a particular reason?
How can I change the width of the dialog, as the new width is a bit too small (for me)?

[afollestad]

This is matching Google's newer spec

[joey-harward]

Is there a way to override this width to be more like 2.0.3? It is definitely too small for me too.

By the way, all your screenshots still reflect the larger widths :)

[guger]

I'd also like to customize the width, especially for the datepicker, this width is too small.

[masc3d]

I'd also like to customize the width, especially for the datepicker, this width is too small.

yes, there's quite a few scenarios where large margins are not suitable. also it doesn't look good.

@afollestad which spec btw looking@ https://material.io/design/components/dialogs.html# does not show such margins.

[afollestad]

The specs show a width of 280dp

[joey-harward]

I have a lot of custom dialog scenarios where that width does not work. And I agree with @guger definitely not for datepicker. Is there any way to expose md_dialog_max_width so we can override?

I really appreciate your work on this library. One of the best!

[afollestad]

Yes, but it may get a more complex than that - the value is different for values, values-land, values-sw600dp, etc.

It seems unideal to make consumers have to remember to have different values for different screen dimens.

[joey-harward]

You are correct, normal consumers should not have to remember different values, but power users should at least have the option to override?

No worries I'll stick with 2.0.3 :) Thanks again for your work!

[masc3d]

thanks @afollestad

customization option is great.

inconsistency with spec is probably because your library can do much more than spec is designated for, so my suggestion would be custom size > spec width in case measured view is within bounds > previous version standard width which would neatly cover all use cases with minor consumer impact.

[cioccarellia]

Agree, this library shouldn't strictly follow all the specs since some of them don't really make sense if applied over here.

Great work anyways :)

[jahirfiquitiva]

I agree there should be either a way to set a custom max width, or some changes done to the library ... It looked so much better before @afollestad 😕 😞

Here's a comparison from a picture in the Material Design specs and one from my app

| Material Design Specs | My App using v 2.6.0 |
|-----------------------|----------------------|
| | |

[afollestad]

I've restored the previous max width values before they shrunk. Keeping the maxWidth() setter around as well.