Markbind: Remove Affix component

Created on 1 Aug 2020  路  6Comments  路  Source: MarkBind/markbind

The vue-components package contains an Affix.vue component, which seems to be undocumented nor used anywhere.

Was this a long-ago deprecated feature?

question

All 6 comments

@damithc did you come across this before? <affix>...</affix>

@damithc did you come across this before? <affix>...</affix>

It was never a user-facing feature of MarkBind

Hmm just found this https://github.com/MarkBind/vue-strap/pull/44, but if it was never intended to be there we could remove it now

Does it work as intended, even when there are other sticky elements in the page such as topnav, sitenav, and pagenav?

seems like it was being used for the docs before https://github.com/MarkBind/markbind/issues/266.

just tried it out as well, some of the implementation (classes particularly) required to make it work had already been removed, so it dosen't work.

Does it work as intended, even when there are other sticky elements in the page such as topnav, sitenav, and pagenav?

We switched to alternate implementations for these as well, could remove it as such. There's also not much value in having <affix>...</affix> over <div class="position-sticky"> I think, since you generally shouldn't have to worry about content responsiveness (<affix> hiding it on smaller screens versus position-sticky) when writing content

Sure, let's remove it.

Was this page helpful?
0 / 5 - 0 ratings