Markbind: Rendering issue related to angle brackets

[damithc]

[damithc]

@danielbrzn can have a look?

[danielbrzn]

On it.

[danielbrzn]

I just built the site locally and am unable to repro:

[damithc]

I'm using v1.6.0 🤔

[danielbrzn]

Odd, I'm using the same version as well..

Does rendering it locally cause the same problem?

[damithc]

I built it locally just now and I get the same problem. Are you building this site? https://github.com/nus-te3201/website

BTW, it seems to render correctly in previous version because it appear correctly in CS2103 website https://nus-cs2103-ay1718s2.github.io/website/book/uml/classDiagrams/classes/ (they are using the previous version of markbind)

[danielbrzn]

Yup that's exactly what I cloned. I tried building with the npm version of markbind and my local copy of markbind, both yielded the correct output :(

Were there any changes made to the pages?

[nicholaschuayunzhi]

I built mine recently with the latest version of markbind. https://nicholaschuayunzhi.github.io/website/book-adapted/index.html

Looks fine:

Not sure if related but, could it be the script that you are running?

[damithc]

There were some changes but I reverted them just now and checked again with the same result. I'm not using any script this time. Just markbind serve

[danielbrzn]

If you took the "Draw Car Class" example out and put it into a small test site, does it render properly?

I notice it's not the only problem in the site, there's actually 3 other code snippets with the same problem inside the same site, and it's always to do with angled brackets.

[damithc]

I just cloned the repo in my other computer and ran served it using 1.6.0. It shows the same error. So it cannot be something wrong in my computer. Either of you using Windows?

[danielbrzn]

Yeah we're both on Windows

[damithc]

If you took the "Draw Car Class" example out and put it into a small test site, does it render properly?

Tried it. No luck. This is very strange.

[damithc]

This is handled by vue-strap module? Is it possible that I have the older version of it? Anyway to check?

[danielbrzn]

Hm, the fix for angled brackets was done in htmlparser so I don't think it's a vue-strap issue.

[damithc]

Is it possible that I have the older version of htmlparser ?

[danielbrzn]

That's a possibility. Could you run npm list in your Markbind directory and let me know what the output is?

[damithc]

+-- [email protected]
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | `-- [email protected] deduped
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | | +-- [email protected] deduped
| | | `-- [email protected] deduped
| | `-- [email protected]
| |   `-- [email protected] deduped
| +-- [email protected]
| | +-- [email protected]
| | `-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | `-- [email protected]
| |   +-- [email protected]
| |   +-- [email protected] deduped
| |   +-- [email protected]
| |   +-- [email protected]
| |   +-- [email protected]
| |   +-- [email protected]
| |   | `-- [email protected] deduped
| |   `-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| `-- [email protected]
+-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | +-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected]
| | | +-- [email protected]
| | | | +-- [email protected]
| | | | | `-- [email protected]
| | | | |   +-- [email protected]
| | | | |   | `-- [email protected] deduped
| | | | |   +-- [email protected]
| | | | |   | `-- [email protected] deduped
| | | | |   +-- [email protected]
| | | | |   | +-- [email protected]
| | | | |   | | `-- [email protected]
| | | | |   | |   `-- [email protected] deduped
| | | | |   | `-- [email protected]
| | | | |   |   `-- [email protected] deduped
| | | | |   +-- [email protected] deduped
| | | | |   `-- [email protected]
| | | | +-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected]
| | | | `-- [email protected] deduped
| | | +-- [email protected]
| | | +-- [email protected] deduped
| | | +-- [email protected] deduped
| | | +-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected] deduped
| | | +-- [email protected]
| | | | +-- [email protected]
| | | | | `-- [email protected]
| | | | `-- [email protected]
| | | +-- [email protected]
| | | | +-- [email protected]
| | | | | +-- [email protected] deduped
| | | | | `-- [email protected] deduped
| | | | +-- [email protected]
| | | | +-- [email protected] deduped
| | | | `-- [email protected] deduped
| | | `-- [email protected]
| | |   `-- [email protected]
| | |     `-- [email protected]
| | `-- [email protected]
| |   `-- [email protected]
| +-- [email protected]
| +-- UNMET OPTIONAL DEPENDENCY fsevents@^1.0.0
| +-- [email protected]
| | `-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| `-- [email protected]
|   +-- [email protected] deduped
|   +-- [email protected]
|   | `-- [email protected]
|   |   +-- [email protected]
|   |   `-- [email protected]
|   +-- [email protected] deduped
|   `-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
| +-- [email protected] deduped
| `-- [email protected]
|   +-- [email protected] deduped
|   +-- [email protected]
|   | `-- [email protected] deduped
|   +-- [email protected]
|   | `-- [email protected] deduped
|   +-- [email protected] deduped
|   `-- [email protected] deduped
+-- [email protected]
| +-- [email protected]
| | `-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected] deduped
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | | +-- [email protected]
| | | +-- [email protected]
| | | | +-- [email protected] deduped
| | | | `-- [email protected]
| | | +-- [email protected] deduped
| | | +-- [email protected] deduped
| | | +-- [email protected]
| | | | `-- [email protected] deduped
| | | `-- [email protected] deduped
| | +-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| |   `-- [email protected]
| +-- [email protected]
| `-- [email protected]
|   `-- [email protected] deduped
+-- [email protected]
+-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| `-- [email protected]
|   `-- [email protected]
+-- [email protected]
| +-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | | +-- [email protected] deduped
| | | +-- [email protected] deduped
| | | +-- [email protected] deduped
| | | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected] deduped
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected] deduped
| | `-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| |   +-- [email protected]
| |   `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected]
| | | +-- [email protected]
| | | +-- [email protected] deduped
| | | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected]
| | +-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected]
| | `-- [email protected]
| `-- [email protected]
|   +-- [email protected]
|   | +-- [email protected] deduped
|   | `-- [email protected]
|   +-- [email protected]
|   +-- [email protected]
|   | `-- [email protected]
|   +-- [email protected] deduped
|   +-- [email protected] deduped
|   +-- [email protected]
|   | `-- [email protected]
|   `-- [email protected] deduped
+-- [email protected]
| +-- [email protected] deduped
| +-- [email protected] deduped
| +-- [email protected]
| +-- [email protected] (github:MarkBind/htmlparser2#815b507c5268a178fa24741d6f74fcc0bc9be4cd)
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | +-- [email protected] deduped
| | `-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | | `-- [email protected]
| | +-- [email protected] deduped
| | +-- [email protected]
| | | `-- [email protected] deduped
| | +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| | `-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected]
| | +-- [email protected]
| | `-- [email protected] deduped
| +-- [email protected]
| +-- [email protected]
| +-- [email protected] deduped
| `-- [email protected] deduped
+-- [email protected]
| +-- [email protected]
| +-- [email protected]
| +-- [email protected] deduped
| +-- [email protected]
| `-- [email protected]
|   +-- [email protected]
|   +-- [email protected]
|   | +-- [email protected] deduped
|   | +-- [email protected] deduped
|   | `-- [email protected]
|   |   +-- [email protected] deduped
|   |   `-- [email protected] deduped
|   +-- [email protected]
|   +-- [email protected]
|   | `-- [email protected]
|   |   `-- [email protected]
|   +-- [email protected]
|   | +-- [email protected]
|   | +-- [email protected]
|   | | `-- [email protected]
|   | `-- [email protected] deduped
|   +-- [email protected]
|   `-- [email protected]
+-- [email protected]
`-- [email protected]
  +-- [email protected]
  `-- [email protected]
    `-- [email protected] deduped

[danielbrzn]

Okay I managed to repro it, turns out that markbind-cli package on npm is pulling the old version of htmlparser instead of our fixed version. I'll see how we can fix this.

[damithc]

Let's do another release as soon as we fix this. I can't ask CS2103 crew to update to new version due to this issue, but part of their website will be losing left-padding in questions because I've updated the css file of the se-book repo (shared between TE3201 and CS2103).

[danielbrzn]

Will try to put out a PR to fix this by tonight.