Maptool: Repos error message missing end '

[Merudo]

Describe the bug
If the repo is not valid, the log message reports the URL with a missing '.

To Reproduce
Steps to reproduce the behavior:

1. Add an invalid repo to a campaign, such as http://dl.dropboxusercontent.com/s/bpujigvo57q1gzs/index.gz
2. Load the campaign. It shows an error such as

ERROR net.rptools.maptool.model.AssetLoader - I/O error retrieving/saving index for 'http://www.rptools.net/image-indexes/gallery.rpax.gz

1. Notice the ' in front of the url, but not at the end of it.

Expected behavior
There is a ' both in front and at the end.

MapTool Info

• Version: 1.7, devlop
• Install: New

Desktop (please complete the following information):

• OS: Windows
• Version: 10

[Merudo]

This could be fixed together with #715

[cwisniew]

@Merudo About the /... It depends, its a common misconception that you have to use \ for windows paths in java this is not the case (and generally not desirable as its clumsy and more prone to portability issues as you introduce a special case for one OS). / Works for both unix and windows, \ only works for windows. The path is abstract so not necessarily the path string required by the OS (although the java doc does say it will also respect underlying OS seperators which is why \ works on windows).

If it was failing then it should have popped up when any windows user uses a repo (unless the exception is ignored, which is hopefully not the case).

If it truely gives you the heebie geebies I suppose you can change it but please use the Paths.get() function to build the path, not checking OS and changing to an uneeded \
(and yes I am aware File.separator exists but using it is still clumsy and not required :) )

[Azhrei]

I saw that your PR expires the index daily. Is there any reason why the time stamp from the server can’t be used to expire the index only when it changes or when the file disappears from the URL?

[Merudo]

That's a good idea! I don't know how to to get the time stamp without downloading the whole file though.

[Phergus]

As the index files are likely to be less than 10k in size it's probably not worth the effort.

[Phergus]

Tested. Error message localized and no longer has unmatched quote mark. Error dialog opens when server is running otherwise message is printed to Chat window.