Maps: Displaying of tracks not working (with Theming app disabled)

[escoand]

Thanks for this nice app. Finally all the geo tags in my pictures have more sense than my technical interest. I'm really happy.

But I've a problem with my tracks. I can see the /index.php/apps/maps/tracks endpoint is delivering the data correctly but instantly throw an error:

TypeError: OCA.Theming is undefined[Weitere Informationen]
tracksController.js:280:13
addTrackMap   https://.../apps/maps/js/tracksController.js:280:13
getTracks/<   https://.../apps/maps/js/tracksController.js:416:17
u             https://.../core/js/dist/main.js:39:22734
fireWith      https://.../core/js/dist/main.js:39:23546
k             https://.../core/js/dist/main.js:39:70718
t/<           https://.../core/js/dist/main.js:39:74242

[jancborchardt]

Looking at the error message – did you disable the "Theming" app? Then cc @juliushaertl

Otherwise cc @tacruc @eneiluj :)

[skjnldsv]

@juliushaertl is the theming expert @jancborchardt :)

[jancborchardt]

@skjnldsv haha, I actually wanted to cc @juliushaertl, didn’t notice I did not! Must be muscle-memory :heart:

[escoand]

@jancborchardt you're right, with theme app enabled it's working. But I don't do and don't want to use it.

[jancborchardt]

Right, thanks for checking! :) So the app should still work with Theming disabled. I assume this is cause tracks are by default colored with the theming color.

What’s the best course of action here @juliushaertl @eneiluj @tacruc? Seems just a check whether Theming exists is missing, and when there’s no theming it could use the default Nextcloud blue #0082c9 as fallback?

[juliushaertl]

OCA.Theming ? OCA.Theming.color : '#0082c9' should do the trick. Note that whenever you use something in the OCA namespace make sure to check that it is actually available, since those are app related and might be disabled/not loaded by default.

[tacruc]

@escoand Do you manage to check if PR #140 solves the problem for you?

[escoand]

@tacruc fix is working for me