Mapbox-gl-js: querySourceFeatures returns invalid feature coordinates on high zoom levels

Created on 30 Nov 2016  路  10Comments  路  Source: mapbox/mapbox-gl-js

If the map zoom level > 16 the features returned from map.querySourceFeatures have invalid geometry coordinates (negative or otherwise nonsense).

https://jsbin.com/sesafumovi/edit?html,console,output

Can be reproduced on current master branch.

bug

Most helpful comment

This is probably yet another consequence of #2868. I'm in process of refactoring this, after which it'll probably become clear how to fix this.

All 10 comments

This is probably yet another consequence of #2868. I'm in process of refactoring this, after which it'll probably become clear how to fix this.

@mourner Would you have any ideas about workarounds until the issue is fixed?

It appears to happen at any zoom level higher than the max zoom level of my tileset. If that is the case, a workaround might be to create tiles for the higher zoom levels.

@data-ux change mentioned by @drewbo in #2868 (swapping z and actualZ) is a valid workaround for me

@bdon Thanks! That change seems to fix my test case.

Any update / workaround on this ? I don't get the z thing, since only x and y are concerned. Am I missing something ?

Plus, I'm having this issue with a vector mapbox style layer

Any update on this? I'm having this problem as well with a mapbox style layer

I would love to see a fix for this.

@bdon Your tweak seems to work for me as well

@cyrilchapon Open dist (or whichever gl-js file you are looking at) and swap the two values in the ternary operator: https://github.com/mapbox/mapbox-gl-js/blob/de61bbfa21f070e7afbe4fd42e24e8e44e7e25f1/js/source/tile_pyramid.js#L151

Hint if you're looking at a minified source, search for i,n,t.reparseOverscaled?o:i, and swap the o and i around

This is still not fixed on 0.51.0 - it's better, but if you keep zooming in the heat map will disappear. The only fix so far was the one from above, however the code has changed so much since it's no longer an option.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

aendrew picture aendrew  路  3Comments

samanpwbb picture samanpwbb  路  3Comments

aderaaij picture aderaaij  路  3Comments

foundryspatial-duncan picture foundryspatial-duncan  路  3Comments

Scarysize picture Scarysize  路  3Comments