Mapbox-gl-js: remove `map.batch` and automatically batch style changes

Created on 25 Mar 2016 · 6Comments · Source: mapbox/mapbox-gl-js

I think we should automatically batch all style changes that happen between frames. Are there any cases where we wouldn't want to batch style changes?

If changes are automatically batched we can remove map.batch.

performance

Source

ansis

Most helpful comment

I think this is safe and good, we're effectively taking methods that were partially sync and partial async and pushing the balance more towards async. It could break a user if they made a mutation and expected to be able to query against it immediately. Given that the stylesheet mutation can still be done sync before deferring the heaving lifting async, this should be fine.

scothis on 28 Mar 2016

👍3

All 6 comments

Yes, I think this would be ideal, although implementation may be tricky. cc @scothis

mourner on 26 Mar 2016

scothis on 28 Mar 2016

👍3

Yeah, it would be nice to have the style API work like the DOM API: mutations are reflected immediately in subsequent API accessor methods, but as much heavy work as possible is delayed until the next frame tick, at which time duplicate work is coalesced.

jfirebaugh on 28 Mar 2016

👍1

I propose that we

run batch operations on every frame, efficiently skipping no-ops.
modify StyleLayer#cascade to only touch properties that have changed since the last cascade