Magisk Manager repeating the Magisk installation when changing the interface language

Created on 19 Apr 2020  路  3Comments  路  Source: topjohnwu/Magisk

I don't know if it's a known problem, but at least for me the MM Canary Debug is not updating itself using the same package name as the current repackaged version. For this reason, I am returning MM to its original package name when I need to update it. Today, I noticed something interesting: after updating the MM and then installing the Magisk update, I went to the MM settings and changed the language and this caused the MM to automatically open the flash screen and then install the Magisk update again. I changed the language a few times and every time Magisk was installed directly again.
ZenFone 4 with Android 9
installingagain.txt

regression

Most helpful comment

@osm0sis the current activity restart logic resends the intent. Might consider sending an empty intent instead to fix this issue. @diareuse I'll handle this myself once I'm done with the native stuffs.

All 3 comments

I followed your steps and I can't reproduce this. Neither with Manager hidden or normal. How did you start the update? Was it using the update notification?

Might be something for @diareuse to look into.

@osm0sis the current activity restart logic resends the intent. Might consider sending an empty intent instead to fix this issue. @diareuse I'll handle this myself once I'm done with the native stuffs.

Fixed 867bab8513ca30c8767cb8706b6088c90a932697

Was this page helpful?
0 / 5 - 0 ratings

Related issues

betaxab picture betaxab  路  4Comments

guitardedhero picture guitardedhero  路  3Comments

Ralozey picture Ralozey  路  4Comments

auanasgheps picture auanasgheps  路  4Comments

xmxrtyx picture xmxrtyx  路  4Comments