Magisk: Provide alternate method for Restore Images

[drewg13]

I use Magisk with a Pixel 3. With the latest OTA that was pushed, I was unable to follow the OTA upgrade method, as I received a "Stock backup does not exist" error at the Restore Images step. I assume this is because the manual boot image patching installation method does not have a step where it is able to create the backup of the boot image. Normally, this would not be an issue because I could just reflash the stock boot image and install Magisk via the TWRP flash method, which would create the necessary backup. Unfortunately, there is no TWRP yet available for Android 10 and there may or may not be one, due to changes in the Android recovery process.

So my request is this, either:
Modify the manual boot image patching method to create the necessary backup

or

From the Restore Images uninstallation step, allow the user to supply a stock boot.img file from internal storage to complete the process

This would allow users to make use of the much simpler OTA upgrade process while there is no TWRP available.

Thanks for providing and maintaining this program, I very much appreciate being able to control adblocking processes manually, along with the many useful modules.

[skittles9823]

I second this suggestion. Would be great to be able to manually point to a boot.img.

Only thing is you'd have to get the boot image from the updated firmware again every OTA, unless magisk can get it from the OTA and back it up then?

[Nephiel]

This would be a godsend for OTAs in Android 10 devices. Right now, without a working TWRP, the only methods are:

• fastboot flashing stock boot first, then normal update or OTA sideload,
• fastboot flashing full factory image without -w flag to keep data.

FWIW I've tried patching the stock boot.img file using Magisk Manager and, while it does state during the process that it is creating a backup, it does not seem to store it or keep it anywhere.

[reyqn]

The backups should be kept in /data (/data/stock_boot_\ You could probably edit /sbin/.magisk/config to point to the backup you want by putting your \

[Nephiel]

Thanks! The SHA1 in /sbin/.magisk/config was correct, so I simply gzipped the stock boot image, renamed it and placed it in /data as instructed. Magisk Manager picked it up for uninstall, OTA applied and Magisk reinstalled without issue.

[juston40]

.......awe 🤔🤔🤔🤔🤔

On Dec 25, 2019 1:20 AM, Erick Estevão Riva Pramio [e-mail] wrote:

Thanks! The SHA1 in /sbin/.magisk/config was correct, so I simply gzipped the stock boot image, renamed it and placed it in /data as instructed. Magisk Manager picked it up for uninstall, OTA applied and Magisk reinstalled without issue.

it doesn't work for me :(

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftopjohnwu%2FMagisk%2Fissues%2F1870%3Femail_source%3Dnotifications%26email_token%3DAIXJVJTTCNMZIDLU6KWFPXTQ2MCT7A5CNFSM4I2FXUHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHUAXGQ%23issuecomment-568855450&data=02%7C01%7C%7C2a2738f74c674747d1ed08d7890aed4c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637128552325960410&sdata=It41INZcGsC1AeGdWl4fpwoMClk0j%2B62MfLPM626MD4%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAIXJVJUPXOJM6BJQDZS63FTQ2MCT7ANCNFSM4I2FXUHA&data=02%7C01%7C%7C2a2738f74c674747d1ed08d7890aed4c%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637128552325970415&sdata=7c9n9CGeqLmAoakJ%2F%2FIrpazKy24E15S8%2Bwup6RqN9IQ%3D&reserved=0.

[erickriva]

please, someone tell me if i'm doing something wrong ...
my file name is following the pattern "stock_boot_< sha1 >.img.gz", with the SHA1 coming from "boot.img" that is inside .gz file, and it's the same from "sbin/.magisk/config"... wouldn't it be like this?

[SgtSeppel]

I just tried that

The backups should be kept in /data (/data/stock_boot_.img.gz)
You could probably edit /sbin/.magisk/config to point to the backup you want by putting your after SHA1=

I just tried this and it worked without issues.
Only problem I see is that after that, the file under /data/stock_boot_.img.gz is removed again and the hash in /sbin/.magisk/config changed. Even though no file is stored under /data/...

[erickriva]

I just tried that

The backups should be kept in /data (/data/stock_boot_.img.gz)
You could probably edit /sbin/.magisk/config to point to the backup you want by putting your after SHA1=

I just tried this and it worked without issues.
Only problem I see is that after that, the file under /data/stock_boot_.img.gz is removed again and the hash in /sbin/.magisk/config changed. Even though no file is stored under /data/...

what are the permissions and owner for this file? I think that another app had changed permissions for this file, maybe this is the reason to don't work for me

[MasterPlexus]

For me (also after reading the source) is not clear what is the difference between /data/magisk_backup_$SHA1 folder where a Boot.img.gz will be stored, and the
/data/stock_boot_hash.img.gz
are they not the same? Why it is needed to build up the file /data/stock_boot_hash.img.gz manually?

[topjohnwu]

This seems like something a root app should handle, and not directly included into Magisk as there are already too many features to keep up with.