Magento2: Upgrade 2.3.3 to 2.3.4 with Dotdigitalgroup_Email disabled

[onepack]

Preconditions (*)

1. Magento 2.3.4
   2.

Steps to reproduce (*)

1. Disable the Dotdigitalgroup_Email module in 2.3.3 and upgrade Magento 2 to 2.3.4
2. After upgrading via composer login to the backend of magento2.

Expected result (*)

1. Expected to dashboard

Actual result (*)

I got an error page with the following:
Exception #0 (OutOfRangeException): Specified invalid parent id (Dotdigital group Email::marketing automation)

[m2-assistant[bot]]

Hi @onepack. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@onepack do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[onepack]

Enabling the module fixes the backend but the backend should not break on a disabled third-party module!

[devchris79]

I have attempted an upgrade with Dotdigitalgroup_Email disabled this morning and get an error report:

{"0":"Specified invalid parent id (Dotdigitalgroup_Email::marketing_automation)","1": "#1 Magento\\Backend\\Model\\Menu\\Builder\\Interceptor->___callParent() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:138] \n#2 Magento\\Backend\\Model\\Menu\\Builder\\Interceptor->Magento\\Framework\\Interception\\{closure}() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:153] \n#3 Magento\\Backend\\Model\\Menu\\Builder\\Interceptor->___callPlugins() called at [generated\/code\/Magento\/Backend\/Model\/Menu\/Builder\/Interceptor.php:26] \n#4 Magento\\Backend\\Model\\Menu\\Builder\\Interceptor->getResult() called at [vendor\/magento\/module-backend\/Model\/Menu\/Config.php:148] \n#5 Magento\\Backend\\Model\\Menu\\Config->_initMenu() called at [vendor\/magento\/module-backend\/Model\/Menu\/Config.php:111] \n#6 Magento\\Backend\\Model\\Menu\\Config->getMenu() called at [vendor\/magento\/module-backend\/Model\/Url.php:365] \n#7 Magento\\Backend\\Model\\Url->_getMenu() called at [vendor\/magento\/module-backend\/Model\/Url.php:325] \n#8 Magento\\Backend\\Model\\Url->getStartupPageUrl() called at [vendor\/magento\/module-backend\/App\/AbstractAction.php:281] \n#9 Magento\\Backend\\App\\AbstractAction->_processUrlKeys() called at [vendor\/magento\/module-backend\/App\/Request\/BackendValidator.php:175] \n#10 Magento\\Backend\\App\\Request\\BackendValidator->validate() called at [vendor\/magento\/framework\/App\/Request\/CompositeValidator.php:40] \n#11 Magento\\Framework\\App\\Request\\CompositeValidator->validate() called at [vendor\/magento\/framework\/App\/FrontController.php:137] \n#12 Magento\\Framework\\App\\FrontController->processRequest() called at [vendor\/magento\/framework\/App\/FrontController.php:98] \n#13 Magento\\Framework\\App\\FrontController->dispatch() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:58] \n#14 Magento\\Framework\\App\\FrontController\\Interceptor->___callParent() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:138] \n#15 Magento\\Framework\\App\\FrontController\\Interceptor->Magento\\Framework\\Interception\\{closure}() called at [app\/code\/Infortis\/Cgen\/Plugin\/Magento\/Framework\/App\/FrontController.php:32] \n#16 Infortis\\Cgen\\Plugin\\Magento\\Framework\\App\\FrontController->aroundDispatch() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:135] \n#17 Magento\\Framework\\App\\FrontController\\Interceptor->Magento\\Framework\\Interception\\{closure}() called at [vendor\/magento\/framework\/Interception\/Interceptor.php:153] \n#18 Magento\\Framework\\App\\FrontController\\Interceptor->___callPlugins() called at [generated\/code\/Magento\/Framework\/App\/FrontController\/Interceptor.php:26] \n#19 Magento\\Framework\\App\\FrontController\\Interceptor->dispatch() called at [vendor\/magento\/framework\/App\/Http.php:116] \n#20 Magento\\Framework\\App\\Http->launch() called at [generated\/code\/Magento\/Framework\/App\/Http\/Interceptor.php:24] \n#21 Magento\\Framework\\App\\Http\\Interceptor->launch() called at [vendor\/magento\/framework\/App\/Bootstrap.php:261] \n#22 Magento\\Framework\\App\\Bootstrap->run() called at [index.php:39]\n","url":"\/admin\/index\/index\/key\/xx\/","script_name":"\/index.php","report_id":"xx"}

[m2-assistant[bot]]

Hi @srsathish92. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[ghost]

:white_check_mark: Confirmed by @srsathish92
Thank you for verifying the issue! :+1: Your confirmation will help us to acknowledge and process this report.

[magento-engcom-team]

@srsathish92 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• [ ] Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess
• [ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[srsathish92]

@onepack Instead of enabling Dotdigitalgroup_Email, you can also disable Dotdigitalgroup_Chat. It will solve the issue.
FYI: Dotdigitalgroup_Chat added in new release.

[onepack]

@srsathish92 I noticed the new module later today and suspected this. I will disable both now. Is it an idea to work in a different way with dependencies regarding non-core modules?

[srsathish92]

@onepack As of now, No. We need to do manually. I thought purposefully added on exception in app/code/Magento/Backend/Model/Menu/Builder.php Line: 83 .

@engcom-Bravo @magento-engcom-team please add the valid label for triage.

[ruggi69]

To solve the issue I changed parent attribute in line 5 in /vendor/dotmailer/dotmailer-magento2-extension-chat/etc/adminhtml/menu.xml
from "Dotdigitalgroup_Email::marketing_automation" to "Magento_Backend::marketing"

[magento-engcom-team]

:white_check_mark: Confirmed by @sudheers-kensium
Thank you for verifying the issue. Based on the provided information internal tickets MC-30914 were created

Issue Available: @sudheers-kensium, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

[adamrandazzo]

Magento really needs to stop including this crapware with the core packages.

[gwharton]

It also breaks di compile if dotdigital email is disabled but chat is enabled.

[inkobject]

Magento really needs to stop including this crapware with the core packages.

At the very least offer the option disable the packages prior to deployment, if not default to new/improved 3rd party packages being disabled altogether.

I ran into this problem and had to determine what was breaking. Nearly all of my upgrade/update pains in 2.3.* have come from bundled modules. I'm looking at you temando #25979

[onepack]

@inkobject Yes, Temando has been a real pain...

[gcampedelli]

I had the same problem with Temando and something with DotMailer version blocking composer from upgrading. Had to manually edit composer to achieve upgrade. I don't use nor Temando or DotMailer.

[tuyennn]

Has same issue, crapware on magento

[rparsi-boxycharm]

Check your composer.lock file; ours had all the Dotdigitalgroup modules, removing them and running composer install should permanently remove these crapware modules.

[prateek-karanpuria]

Enable the Dotdigitalgroup_Email module & then executing setup upgrade fixes the issue.
Afterwards, we can again disable the module if not required. For disabling this, we need to first disable Dotdigitalgroup_Chat module & then Dotdigitalgroup_Email.

This issue arises after upgrade as Dotdigitalgroup_Chat module gets added & enabled (by default) which has dependency on Dotdigitalgroup_Email module.

Ref: https://devdocs.magento.com/guides/v2.3/release-notes/release-notes-2-3-4-open-source.html#dotdigital

[rparsi-boxycharm]

Or, as others have mentioned, magento can stop including crapware modules in their releases.

[Finbayern]

Or, as others have mentioned, magento can stop including crapware modules in their releases.

Oh, how I wish that will happen one day. All this crapware could be added as extensions IF needed, now they only create a load of issues in EVERY damn update. Magento is a really fragile (unstable) platform already without all the crapware and by adding all this useless junk, it creates a nightmare. Each update should be easily finished within an hour or a few, but I've gotten used to be prepared for hours of bug-hunting and reverting back to the previous, functional version. Please Magento, make all this crapware an OPTION, not a part of core code that only pushes people to use other platforms with all the constant issues.

[hostep]

Nobody has mentioned this in this thread yet, but if you want to get rid of all dotmailer packages in composer, they have been bundled together in a meta package called dotmailer/dotmailer-magento2-extension-package since Magento 2.3.4 I believe.

So it suffices to just add the following in your composer.json file if you want to get rid of them all (and most likely also all new dotmailer modules which might get added in the future):

    "replace": {
        "dotmailer/dotmailer-magento2-extension-package": "*",
    }

[matthew99]

Oh yes!, thank you @hostep ! I could not compile when updated from 2.3.3 to 2.3.5 due to the digitalgroup-chat module giving errors. You replace command did the trick!

My error was on compilation:
Fatal error: Trait 'Dotdigitalgroup\Email\Block\Adminhtml\HandlesMicrositeRequests' not found in /[magento-root]/vendor/dotmailer/dotmailer-magento2-extension-chat/Block/Adminhtml/StudioChat.php on line 21

After re-requiring the dotdigital modules (trying to get things running) the error on compilation changed to:
Fatal error: Class Dotdigitalgroup\Chat\Block\Adminhtml\StudioChat contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Dotdigitalgroup\Email\Block\Adminhtml\EngagementCloudTrialInterface::getLocalCallbackUrl, Dotdigitalgroup\Email\Block\Adminhtml\EngagementCloudTrialInterface::getTrialSignupHostAndScheme) in /[magento-root]/vendor/dotmailer/dotmailer-magento2-extension-chat/Block/Adminhtml/StudioChat.php on line 21

But after reading your hint made the changes to composer.json

 "replace": {
         "dotmailer/dotmailer-magento2-extension": "*",
         "dotmailer/dotmailer-magento2-extension-enterprise": "*",
    "dotmailer/dotmailer-magento2-extension-package": "*",
 }

And compilation was back.

Every update, there's just some junk throwing errors! Issues like this cost me more than an hour... I could not agree more to keep the core clean (and fragile as it is). I just added some error messages to my reply, maybe that will help others find the solution faster.

[sdzhepa]

Based on the response from Dotdigital (owner of this extension)

After a couple of internal discussions and investigation was defined it is not a bug but not a supported the case.
At this moment Magento does not support partial disable of the module. Please disable all modules related to the extension.
Also, there are no plans to implement and support such case at this moment.