Magento2: Store logo inherits height and width from luma logo, if no height and width is provided

[gwharton]

Preconditions (*)

1. Magento 2.3-develop

Steps to reproduce (*)

1. Create a test logo image of size 400x100 pixels
   
2. Deploy 2.3-develop
3. Content->Configuration->Global->Edit->Header->Upload Logo Image
4. Do not set any height and width in config
5. Refresh cache
6. View frontend and inspect size of logo image

Expected result (*)

1. Logo should be 400x100px.

Actual result (*)

1. Logo is actually 148x43px in size which is the dimensions of luma's logo.svg, even though it is no longer being used.

If the height and width is set in design config to 400x100 pixels, the logo is displayed correctly.

If no height and width are set in config, it should determine them from the actual logo, not luma's logo.

[m2-assistant[bot]]

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• [x] Summary of the issue
• [x] Information on your environment
• [x] Steps to reproduce
• [x] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gwharton do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [x] yes
• [ ] no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant[bot]]

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

:white_check_mark: Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-21772 were created

Issue Available: @krishprakash, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

[vivekkumar945744]

@magento I am working on it.

[m2-assistant[bot]]

Hi @vivekkumar-webkul! :wave:
Thank you for joining. Please accept team invitation :point_right: here :point_left: and self-assign the issue.

[m2-assistant[bot]]

Hi @vivekkumar-webkul. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant[bot]]

Hi @mfickers. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[mfickers]

cd-cologne19

[VladimirZaets]

Hi @gwharton. Thank you for your report.
The issue has been fixed in magento/magento2#25789 by @mfickers in 2.3-develop branch
Related commit(s):

• 9abcf547c0d5160de4cfa0c5e3b907056fb8f311
• 136cb0400b7e8beb50be8a4bef75c62ff08b0937

The fix will be available with the upcoming 2.3.5 release.

[hostep]

In case people see a different sized logo after upgrading to Magento 2.3.5, please follow the advice from @mfickers and update your layout xml from:

        <referenceBlock name="logo">
            <arguments>
                <argument name="logo_img_width" xsi:type="number">xxx</argument>
                <argument name="logo_img_height" xsi:type="number">yyy</argument>
            </arguments>
        </referenceBlock>

to:

        <referenceBlock name="logo">
            <arguments>
                <argument name="logo_width" xsi:type="number">xxx</argument>
                <argument name="logo_height" xsi:type="number">yyy</argument>
            </arguments>
        </referenceBlock>

(yet another backwards compatibility breaking fix added in a minor release)