Magento2: "Vertex Settings" has the extra line at the bottom

[edenduong]

Preconditions (*)

1. Magento version 2.3.2
2. PHP 7.1.30

Steps to reproduce (*)

1. Go to the Backend,
2. Configuration->Sales/Tax
3. Check the display of Vertex Settings

Expected result (*)

1. It has no extra line at the bottom (the normal style)

Actual result (*)

1. It has the extra line at the bottom
   

[m2-assistant[bot]]

Hi @edenduong. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• [ ] Summary of the issue
• [ ] Information on your environment
• [ ] Steps to reproduce
• [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@edenduong do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• [ ] yes
• [ ] no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant[bot]]

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [x] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [x] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [x] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
  

• [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• [ ] 6. Add label Issue: Confirmed once verification is complete.

• [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

[edenduong]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @edenduong. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @edenduong, here is your Magento instance.
Admin access: https://i-23676-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ajijshekh123]

Give me @magento give me 2.3-develop instance

[magento-engcom-team]

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-23676-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ajijshekh123]

Give me @magento give me 2.2-develop instance

[magento-engcom-team]

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-23676-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ajijshekh123]

@edenduong - In Default Magento 2.2 and 2.3 Instance, Vertex options are not available in below Configuration. Stores >> Configuration >> Sales >> Tax.
See attached below screenshot:

@edenduong - Can you please let me know how to configure Vertex Settings?

[edenduong]

Hello @ajijshekh123,

It seems in this repository, it doesn't have this module. Because I install the magento version in

https://magento.com/tech-resources/download

So the source code is different. You can close this issue.

Thank you very much!

[ajijshekh123]

Okay, @edenduong.
Thanks for the Update.

[hostep]

In theory you should report this bug to https://github.com/magento/ext-vertex/ (but that's still not accessible at the moment of writing)

According to @okorshenko it was going to be opened to the public one day, but until now this doesn't seem to have happened yet :(

[navarr]

This is kind of a Magento bug, but I don't know that any core modules replicate it.

The extra-thick/multiple lines are caused by several sections being hidden. Vertex does not do any custom styling here.

I have plans to turn those sections into subsections instead, but that's a little further on the roadmap.

[hostep]

Ok thanks for the explanation @navarr. Sounds like a Magento bug, let's reopen this then :)

[navarr]

Issue here is that when vertex is set to disabled, all of the Vertex sections disappear (b/c they depend on "enabled"). When that happens, only the fieldsets below them are set to display: none; - which means the div.config-section still is displayed, and it is what contains the border.

[m2-assistant[bot]]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

• [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

• [ ] 5. Add label Issue: Confirmed once verification is complete.

• [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

High everyone. In order to see this bug in action just pull down the latest release of Community Edition via composer.

[magento-engcom-team]

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• [ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[magento-engcom-team]

:white_check_mark: Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-20221 were created

Issue Available: @engcom-Bravo, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

[hostep]

The same issue can be observed on Magento 2.4.0 when you go to Stores > Configuration > Security > Security.txt (when General > Enable is set to No)

[hostep]

@sidolov or @sdzhepa: why was this issue closed without specifying any reason?

[sdzhepa]

Hello @hostep

Thank you for letting me know about it.
As I can see internal jira ticket has been closed. I suppose as cannot be reproduced on the latest version

@engcom-Delta @engcom-Alfa @engcom-Bravo
Could you please check on the latest version?

• if the initial report still actually, reopen, update, confirm
• Also, please check https://github.com/magento/magento2/issues/23676#issuecomment-665284346 if an issue exists please create a new report in https://github.com/magento/security-package/issues

Update after https://github.com/magento/magento2/issues/23676#issuecomment-708674705

• create issue in this reop instead of sec-pack

[hostep]

@sdzhepa: I can still reproduce the issue in the Security section on Magento 2.4.1

In my opinion this is not a bug in the security-package but in the Magento/backend theme of core Magento. I'm pretty sure that you should be able to create a small simple module to reproduce it outside of the security-package.

Also see the following comment: https://github.com/magento/magento2/issues/23676#issuecomment-511438872

This is super low priority though, so do with it what you want 🙂

[m2-assistant[bot]]

Hi @engcom-Alfa. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 
  
  1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  
  

• 1. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!
• 1. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Delta]

@hostep I rechecked initial issue and it is not reproducible by steps on latest released version 2.4.0.
Result:
:heavy_check_mark: No extra line at the bottom of section

I create issue in security-package repo according your comment for easier investigation. If it is Magento/backend theme issue, fix could be delivered into core Magento

[hostep]

Why do we even bother trying to guide you guys in the correct direction ... Anyway, at least there is an open ticket again but it's in the wrong repo.