Magento2: Magento 2.2.8 Can't save products after updating

Created on 10 Apr 2019  ·  41Comments  ·  Source: magento/magento2

After updating to 2.2.8 I can't save a product after updating it. Clicking the save and close button appears to do nothing. No error messages appear.

Preconditions (*)

Magento 2.2.8
Some third party extensions installed although they have all confirmed for me that it has nothing to do with their extensions.

Steps to reproduce (*)

  1. Make a required field in advanced inventory
  2. Open a product to edit it
  3. Make changes
  4. Click save and close

Expected result (*)

  1. Product saves successfully

Actual result (*)

  1. Nothing happens when the button is clicked. No error messages appear to indicate missing information.

After some useful comments, the cause of this is an error that is thrown in the advanced inventory options. This remains invisible unless the user manually expands the advanced inventory options. An error flag should appear that indicates the location of the error.

Catalog dmcdindia1 imagine2019 Fixed in 2.3.x Clear Description Confirmed Format is valid Ready for Work Reproduced on 2.2.x Reproduced on 2.3.x

Most helpful comment

I faced a similar issue is which was caused by a change on the attribute Maximum Qty Allowed in Shopping Cart. Push the save button and look in modals like Advanced Inventory and search for an error inside modals.

All 41 comments

Hi @Ctucker9233. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • [ ] Summary of the issue
  • [ ] Information on your environment
  • [ ] Steps to reproduce
  • [ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Ctucker9233 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • [ ] yes
  • [ ] no

@magento-engcom-team Give me 2.2-develop instance with sample data

Hi @Ctucker9233. Thank you for your request. I'm working on Magento 2.2-develop instance for you

Hi @Ctucker9233, here is your Magento instance.
Admin access: https://i-22274-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team how can I get some sample data in this instance? Without it, I can't confirm. Adding new products and then later editing those works just fine. It is only products that existed prior to 2.2.8 that are affected.

@Ctucker9233 i expierienced the same problem. For me there where custom settings in the "Advanced Inventory" ("Maximum Qty Allowed in Shopping Cart" was 0 so the form validation failed.) Cost me several hours to figure this out. Maybe its the same for you.

This is probably a missing required product attribute or field in a different tab.
Other than that this issue cannot be reproduced in 2.2.7.

I faced a similar issue is which was caused by a change on the attribute Maximum Qty Allowed in Shopping Cart. Push the save button and look in modals like Advanced Inventory and search for an error inside modals.

@mad-develop at @steinkopffp I will look at that right now. Thank you!

@mad-develop @steinkopffp that was it! Now all we need is for @magento-engcom-team to add an error message that validates advanced inventory so that more people like me don't spend hours banging their heads against a wall.

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • [ ] 6. Add label Issue: Confirmed once verification is complete.

  • [ ] 7. Make sure that automatic system confirms that report has been added to the backlog.

:white_check_mark: Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99265, MAGETWO-99266 were created

Issue Available: @engcom-backlog-nazar, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

"I am working on this at #dmcdindia19”

@Krishnan369 thank you for joining. Please accept team invitation here and self-assign the issue.

Give me 2.2.8-develop instance with sample data

Hi @vidhyasaharJ. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  • [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

Give me 2.2.8-develop instance with sample data

@magento-engcom-team give me 2.3-develop instance

Hi @vidhyasaharJ. Thank you for your request. I'm working on Magento 2.3-develop instance for you

Hi @vidhyasaharJ, here is your Magento instance.
Admin access: https://i-22274-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

give me 2.2.8-develop instance with sample data

@magento-engcom-team give me 2.2.8-develop instance with sample data

Hi @vidhyasaharJ. Thank you for your request. I'm working on Magento 2.2.8-develop instance for you

I also had this problem.

The problem was that Magento tried to focus on the field that was hidden and validation inside vendor/magento/module-ui/view/base/web/js/form/form.js save() function didn't pass and it ended up inside focusInvalid() function. I console logged invalidFieldand in one of the objects parameters I found the field class max_sale_qty and then found it in the html document, removed display: none parameter and there was an error "Please enter a number greater than 0 in this field." (https://prnt.sc/nlvlf4)

Looks like client imported some products and changed use_config_max_sale_qty to 1 or something like that.

So for me, this doesn't seem to be related to upgrading, but hard to tell for 100%.

In short - the problem seems to be that Magento should remove display:none from the field that validation failed so that clients can see the error message.

Cheers

Hi @mallikaverma. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  • [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.


@magento-engcom-team Give me 2.2.8-develop instance with sample data

Hi @mallikaverma. Thank you for your request. I'm working on Magento 2.2.8-develop instance for you

imagine2019

I faced a similar issue is which was caused by a change on the attribute Maximum Qty Allowed in Shopping Cart. Push the save button and look in modals like Advanced Inventory and search for an error inside modals.

My goddess, appreciate your answer, spend quite amount of time lmao

Hi @MaxSouza. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • [ ] 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
  • [ ] 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


Hi everyone,

As this is configuration, I'll close the issue.

@MaxSouza What do you mean this is a configuration problem? Can this configuration be changed?

@Ctucker9233 Sorry, there is an error because the validation field does not display when you tried save product.

@MaxSouza Can you add the tags back that the Magento bot removed?

:white_check_mark: Confirmed by @MaxSouza
Thank you for verifying the issue! :+1: Your confirmation will help us to acknowledge and process this report.

@MaxSouza Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • [ ] Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@Ctucker9233 Done.

@MaxSouza Thank you

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and _stop verification process here_!

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

:white_check_mark: Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-21821 were created

Issue Available: @engcom-Charlie, _You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself._

Hi @Ctucker9233.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.5 release.

Was this page helpful?
0 / 5 - 0 ratings