Magento2: creating new shipment: gettting all trackers. after this commit 2307e16

Created on 20 Dec 2018 · 12Comments · Source: magento/magento2

Preconditions (*)

Magento 2.3-develop

Steps to reproduce (*)

After I pulled 2.3-dev brunch to my code, this commit effected creating new order shipment.
after creating new shipment and exec $_shipment->getAllTracks()
in https://example.com/admin_xxxxx/admin/order_shipment/view/shipment_id/382
after tick Notify Customer by Email and click save
the customer receive email with all my tracking number
also if the order converted to shipment MagentoSalesModelConvertOrder->toShipment($order);
then $shipment->getAllTracks() will return all trackers

Expected result (*)

return trackers if they already exist or empty array if not exist

Actual result (*)

return all tracker in sales_shipment_track table

my temporary fix that work

1- in app/code/Magento/Sales/view/frontend/templates/email/shipment/track.phtml

<?php $_shipment = $block->getShipment() ?>
// my fix
<?php $_shipment->getTracksCollection()->addFieldToFilter('parent_id',array('eq' =>$_shipment->getId())); ?>

in Controller/Adminhtml/Order/Pdfshipments.php

$convertOrder = $objectManager->create('Magento\Sales\Model\Convert\Order');
$shipment = $convertOrder->toShipment($order);
// fix the issue after convert get all shipment trackers
$shipment->getTracksCollection()->addFieldToFilter('parent_id',array('eq' =>$shipment->getId()));

Shipping Fixed in 2.2.x Fixed in 2.3.x Clear Description Confirmed Format is valid Ready for Work Reproduced on 2.3.x

Source

aldf

Most helpful comment

I think you should reopen this issue, because aldf wrote:

also if the order converted to shipment MagentoSalesModelConvertOrder->toShipment($order);
then $shipment->getAllTracks() will return all trackers

and this is still true in 2.2.11: if you get all tracks using converter, you get a result (all tracks for all orders), but if you use method getTracksCollection on order, you get a differente result (just one track, and this is correct).
Here are the steps to reproduce:
Screenshot 2020-02-26 at 10 32 09
I think that the fix provided with commit f8df2dfd8a99202b52480428618f4c33966a7ba1 is just a workaround in the phtml. But if you use $shipment->getAllTracks() in other places in your code, you still get the issue.

fabianaromagnoli on 26 Feb 2020

👍5

All 12 comments

Hi @aldf. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

[ ] Summary of the issue
[ ] Information on your environment
[ ] Steps to reproduce
[ ] Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@aldf do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

[ ] yes
[ ] no