Magento2: PageCache gives error "Uncaught TypeError: element.prop is not a function" when there is an iframe

Created on 30 Sep 2016 · 28Comments · Source: magento/magento2

Preconditions

Magento 2.1.0
PHP 7.0.11

Steps to reproduce

Install Magento 2.1.0 with module Livechat from https://github.com/livechat/magento-livechat
Enable module Livechat: bin/magent module:enable LiveChat_LiveChat
Clear cache: bin/magento c:f
Go to homepage

Expected result

No JavaScript error

Actual result

JavaScript error: Uncaught TypeError: element.prop is not a function

FrameworCache Fixed in 2.1.x Format is valid Ready for Work needs update bug report

Source

PascalBrouwers

Most helpful comment

8months and still not yet in 2.1.7. Insane.

PieterCappelle on 2 Jun 2017

👍13

All 28 comments

The fix is actually pretty easy.

Change line 40 of page-cache.js
.prop('href', element.prop('src'))
To:
.prop('href', $(element).prop('src'))

But I see it is already fixed 2.1.1

PascalBrouwers on 30 Sep 2016

👍5

@PascalBrouwers thanks, we applied this fix also within the page-cache.js

devhn on 30 Sep 2016

@devhn @PascalBrouwers
How come the original file is not fixed yet? I fixed this, last monday I updated to Magento 2.1.3 (from 2.1.2) and now have to apply this fix again.
I use composer to update, so it can be found in the vendor folder.

Tristan-N on 21 Dec 2016

@Tristan-N I was surprised that my 2.1.2 also still has this issue, didn't check 2.1.3 yet.

PascalBrouwers on 21 Dec 2016

👍1

@PascalBrouwers I did too, but didn't pay any attention and just fixed it again, until the update to 2.1.3. It's that simple, so I was a bit surprised too.

Tristan-N on 21 Dec 2016

The weirdest thing is: they did fix it in the develop branch: https://github.com/magento/magento2/blob/develop/app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

PascalBrouwers on 21 Dec 2016

@veloraven Can you make sure this get's into the next release?
It was missed in this release as you can see: https://github.com/magento/magento2/blob/2.1.3/app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

PascalBrouwers on 21 Dec 2016

👍5

It's still happening on 2.14..

erfanimani on 15 Feb 2017

Also happening in 2.1.5.

Hint for fix? https://mage2.pro/t/topic/999/2

petterkj on 24 Feb 2017

@petterkj Magento 2.1.5 doesn't contains any features or patches. It's only to update alle copyright files to the correct year, so this isn't surprising.

http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.5CE.html

This release updates the copyright date in every file. It does not contain any functional changes or security improvements. Isolating these changes in a single release is intended to simplify future updates and developer workflow.

Tristan-N on 24 Feb 2017

When will this fix be included in a release?

brendanmckeown on 7 Mar 2017

Apparently Magento 2.2 will contain all fixes currently in the develop
branch.

On 7 Mar 2017 23:08, "Brendan McKeown" notifications@github.com wrote:

When will this fix be included in a release?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/magento/magento2/issues/6818#issuecomment-284748046,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA4ypjwDHBOOkHmsPb1Xs-Y3WsNNbu3Hks5rjXMDgaJpZM4KLBB9
.

erfanimani on 7 Mar 2017

It's still happening on 2.1.6

shuaiZend on 1 Jun 2017

8months and still not yet in 2.1.7. Insane.

PieterCappelle on 2 Jun 2017

👍13

@PieterCappelle could you please confirm that you use clear Magento 2.1.7 install and the latest version of the Magento LiveChat Module?
Could you also specify which environment do you use? Like OS, web-server, PHP, MySQL version.
We were not able to reproduce this issue, so some additional information is required: maybe some specific environment, or some additional steps.

veloraven on 7 Jun 2017

👎4

The problem is not related to LiveChat, the problem is related to iframes in HTML. See www.sanimarkt.be, is 2.1.7. See the console.

Error is triggered because the chat integration.

PieterCappelle on 7 Jun 2017

@veloraven, the issue appears whenever you have an iframe on the page.
There is no doubt about its existence, plenty of people here have experienced it.

FYI I believe the two fixes that were implemented in scope of the following two PRs cover the issue completely:
https://github.com/magento/magento2/pull/7914
https://github.com/magento/magento2/pull/8005

As far as I understand those just need to be merged into 2.1-develop and put into the next release.
Could maybe consult with @vrann to verify if this assessment is correct?

korostii on 8 Jun 2017

Can also confirm this issue is in 2.1.7

carb0nknight on 28 Jun 2017

👍2

@PieterCappelle Hilarious. 8 months to fix a simple "_typo_", yet they released an update for just copyright files in 2.1.5? Brutal!

It's like @veloraven is a bot or something. That is the only response I see her give on every issue ever, ffs :expressionless:

Off topic: Even funnier - with the 2.1.7 update, I am pretty sure someone screwed up the template blocks in Content > Design > Configuration. The grid is above the filters and options now :laughing:

jordanbrauer on 30 Jun 2017

👍4 😄2

Same issue with a chat that isn't installed as an extension... just added to the page via js... so obviously nothing to do with Livechat module.

I can't believe it hasn't been fixed when the the fixed code has been volunteered. Things like this are putting me off getting enterprise, what good would 24/7 support be if it's this bad?

ghost on 4 Jul 2017

👍3

@xAvarice
Yep agree.

Find bug in production
Go to Github to report it
Find it was reported 12 months ago
Bug acknowledged and "fixed" 12 months ago
Apply fix manually

Things like the devbox not working make me feel like Magento are trying to get the Community users to either move to Enterprise or solve issues themselves.

Personally, I will no longer be recommending Magento as a solution and will be looking into alternatives such as Shopify etc.