Magento2: quotes not escaped for translations of "Not you?" message in persistent header

[ktruehl]

Steps to reproduce

1. Install Magento 2.1.
2. Install the French translation package by Imaginaerum (https://github.com/Imaginaerum/magento2-language-fr-fr).
3. Set up to stores, the first with the default locale (en_US), the second with the locale fr_FR.
4. Do whatever you have to do (activate the persistent shopping cart in the settings, make sure the settings are correct, create a customer account, log into that account, log out again, etc.) do get the "Not you?" message in the header in the store for en_US.

5. Switch to the French store.

   Expected result

6. No Javascript errors. In the header the message "Ce n'est pas vous?" should be displayed.

   Actual result

7. You get the following Javascript error: SyntaxError: missing ; before statement (at least in Firefox, the wording will vary depending on the browser used). The problem will become particularly noticable if you go to the shopping cart page (while having something in the cart) in the store for fr_FR, since the cart summary will not render correctly as a consequence of the first Javascript error.

   Underling problem

In the file vendor/magento/module-persistent/Block/Header/Additional.php in the method _toHtml() the translation of the message "Not you?" is not escaped.

[ktruehl]

I found another occurrence in vendor/magento/module-theme/Block/Html/Header.php in the method getWelcome(). Here the translation of the welcome message is not escaped. In French it's "Message d'accueil par défaut".

[veloraven]

@ktruehl thank you for your report.
Unfortunately I was not able to reproduce this problem.
Please provide some additional information like information about your environment: versions of PHP, MySQL, web server, Firefox versions. Was a new installation or upgrade from some previous version?
Please also provide screenshots for both described cases.

[ktruehl]

MySQL 5.6, PHP 7.0.8, apache, reproducible in any browser. Look at the source code. You'll see why it will have to go wrong, if the welcome message contains a single quote.

[heldchen]

still present in 2.1.1

[andimov]

I've created an internal ticket MAGETWO-58020 for this issue and linked it to this one.

[bh-ref]

issue is still present in 2.1.4

[magento-engcom-team]

@ktruehl, thank you for your report.
We've created internal ticket(s) MAGETWO-58020 to track progress on the issue.

[sidolov]

According to comment in closed pull request this issue has been fixed in 2.2-develop branch