Magento2: 2.1 Cannot upload a .ico as favicon

[matthijsleenen]

Steps to reproduce

1. Install Magento from 2.1 branch.
2. Go to Content / Configuration
3. Edit Default theme
4. Go to Other Settings / HTML Head
5. Click on 'Upload' button for Favicon

6. Select .ico file

   Expected result

7. .Ico file can be uploaded

8. ...

   Actual result

9. Error message appears: "Attention, We don't recognize or support this file extension type.".

In /vendor/magento/module-config/Model/Config/Backend/Image/Favicon.php there is a method _getAllowedExtensions which allows the ico format.

Other filetypes like svg can be uploaded.

[antboiko]

Hi @matthijsleenen , thanks for reporting this issue. We've created internal ticket MAGETWO-55110 to fix it.

Thanks,
Anton.

[pratikkamani]

I have same issue ..
Can we direct replace this icon from FTP . and after compile magento it will effect ?

[lewisvoncken]

@antboiko
Is it possible that this problem is not solved yet?

I found the same problem that not all of the Favicon formats are support. The supported formats in as quoted in de the description are ico, png, gif, jpg, jpeg, apng, svg but actually the supported formats are jpg jpeg gif png svg . The problem can be solved by changing line 70 in module-theme/view/adminhtml/ui_component/design_config_form.xml from
<item name="allowedExtensions" xsi:type="string">jpg jpeg gif png svg</item>
to
<item name="allowedExtensions" xsi:type="string">ico jpg jpeg gif png svg apng</item> .

[antboiko]

Hi @matthijsleenen @lewisvoncken ,
This issue was fixed and delivered to the develop branch. c9c4882
Please check if the issue is still reproducible for you on the develop branch
Thank you.

[lewisvoncken]

@antboiko I installed M2 Enterprise but I got the error there. Is it possible that Enterprise can be udated with this bugfix?

[cuiyang000]

Can confirm, and @lewisvoncken 's solution works!

[noodlenood]

@lewisvoncken
I'm having the same issue, the ico file is not being recognized.
I am also a noob: could you tell me where to exactly enter "line 70"?

Thank you,

[lewisvoncken]

@noodlenood,

You can find it in the develop branch on github
https://github.com/magento/magento2/commit/c9c4882dea9544cb867d76c5d962ef5de6ccf122

_Met vriendelijke groet / Best regards,_

Lewis Voncken
Developer
Arthur van Schendelstraat 650
030 - 8200 238
www.experius.nl

On Sun, Oct 16, 2016 at 10:31 AM, noodlenood [email protected]
wrote:

@lewisvoncken https://github.com/lewisvoncken
I'm having the same issue, the ico file is not being recognized.
I am also a noob: could you tell me where to exactly enter "line 70"?

Thank you,

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/magento/magento2/issues/5478#issuecomment-254034384,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFwrFwMSKR9W4HGETh5fSdCyGEV6MNNGks5q0eDcgaJpZM4JFQrx
.

[keyurshah]

what is the best way to merge changes from a develop branch into the current master branch?

or do you just use the entire develop branch?

thanks.

[timbaker1991]

Is there any estimate of which CE version this would be released in?

[GuidoHub]

Problem is still there in release 2.1.3

[slackerzz]

6 months, no fix :confused:

[springimport]

I had the same problem.

For solve a problem you can Add custom favicons manually from your theme or can use my module with a bugfix.

https://packagist.org/packages/springimport/magento2-module-favicon-bugfix

[lano-vargas]

lewisvoncken Sugestion worked for me Thank's. Yet no updates in the latest release magento 2.1.4.
Does that means if I update magento to 2.1.5 in the very near future the fix I applied will be overwritten? 👎
J

[lewisvoncken]

Hello Juliano,

Great to hear but it is only a temporary fix and it will be overwritten
with the next update.

Met vriendelijke groet / Best regards,

Lewis Voncken
Developer
Arthur van Schendelstraat 650
030 - 8200 238
www.experius.nl

On Wed, Mar 29, 2017 at 4:48 PM, Juliano Vargas [e-mail]
wrote:

lewisvoncken Sugestion worked for me Thank's. Yet no updates in the latest
release magento 2.1.4.
Does that means if I update magento to 2.1.5 in the very near future the
fix I applied will be overwritten? 👎
J

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/magento/magento2/issues/5478#issuecomment-290113809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFwrF1_0BBqE3ZXZnWd5ZhXQNizYE7jwks5rqm8ogaJpZM4JFQrx
.

[robbanl]

It has been almost 10 month ago since this was reported. Still not fixed. Ping @antboiko

[simonsaysforcepush]

This is STILL broken in 2.1.7... Why? There's no reason for this. This is basic functionality, as .ico is the standard accepted format.

[korostii]

@veloraven, could you please an official response regarding.. what takes so long?
The issue is reportedly "fixed", what are the steps for a merchant in order to apply this fix to his Magento instance (if it's not in any of the versions released, as of yet)?

[lingwooc]

For the love of god! Can you guys actually FIX anything? @antboiko

[hostep]

@lingwooc: this fix is available on the 2.1.8-preview branch, so you'll get the fix in the next release :)
See: https://github.com/magento/magento2/commit/406c81796c938a76abed39bf5e5a9dda9218e534

[lingwooc]

At least that's something. Its not really ok it took over a year to add 3 characters to a release though.

[JerryLosey]

Holy crap this is awful. A year to fix favicon without even giving current users a fix? When will 2.1.8 release? ...Probably a year from now.

[scottsb]

@JerryLosey, the 2.1.x series is releasing fairly regularly: about once a month.

[slackerzz]

Better late than never! :smile:

[allininfosystems]

I want to upload logo from admin panel in svg format. I have changed the given your code in that file but it showing a message "Disallowed file type.". Please help me. What I do for fix it

[hostep]

@allininfosystems: uploading of svg files was removed in Magento 2.0.16 and 2.1.9 due to the possibility that svg files can have embedded malicious code, read more over here: https://magento.com/security/patches/magento-2016-and-219-security-update (search for APPSEC-1673).

You can take a look over here (search for 'svg') how it got removed and try to restore that functionality again, but please make sure you double check all your uploaded svg files if the code contents contains nothing malicious.

[allininfosystems]

I am using Magento2.2.2 version and I have checked function _getAllowedExtensions in Logo.php inside core directory there is not available 'svg'. In Magento2.2.2 we can upload svg format header logo from admin or not can you please clarify it?

[lewisvoncken]

@allininfosystems

It is not possible any more to upload svg files for security reasons.

[lano-vargas]

@allininfosystems you will have to update from your theme just place an image named logo.svg inside image/ folder.
More info cam be found here:http://devdocs.magento.com/guides/v2.0/frontend-dev-guide/themes/theme-create.html#theme_logo