Magento-lts: Discussion: Remove app/design/frontend/default/iphone and app/design/frontend/default/modern

[kkrieger85]

Both resources are not up to date.

Google expects (and ranks higher) RWD design.

Also, there is a RWD Design/Approach in default designs.

Proposal: Extract each to mandatory theme-module

[kkrieger85]

Pro: It would make code-review easier (less files)

[luigifab]

Perhaps we can also remove _app/design/frontend/default_ (with all subdirectories) and move _skin/frontend/default_ subdirectories to _skin/frontend/base_ (and we can remove some of them) ? :angel:

[colinmollenhour]

If they are broken I say remove them...

[dng-dev]

I agree totally on that

Colin Mollenhour [e-mail] schrieb am Sa. 13. Juni 2020 um
01:24:

If they are broken I say remove them...

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenMage/magento-lts/issues/1037#issuecomment-643520036,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMD36I2M6E5ED4WMT3EWDRWK2LBANCNFSM4N4DAJ7Q
.

--
Valmano GmbH • Schwedter Straße 263 • 10119 Berlin

Geschäftsführer:
Michael Berghoff, Stefanie Köttendorf
Registergericht:
Berlin-Charlottenburg, HRB 150237 B

This
message and any attachment
are confidential and may be privileged or
otherwise protected from
disclosure. If you are not the intended
recipient,you must not copy this
message or attachment or disclose the
contents to any other person. If you
have received this transmission in
error, please notify the sender
immediately and delete the message and
any attachment from your system.

[Flyingmana]

People may still rely on them in one way or another.
Even if we do changes in this area, we should do this as part of one of the later releases.

Besides that, fully support the removal of them.

[colinmollenhour]

@Flyingmana What about starting a "next-major-release" (or more typically "dev") branch so we can start merging things for the next major release?

[kkrieger85]

So
Step 1: Add deprecation warning for default/iphone and default/modern in current release

Step 2: Move both themes in external theme modules, installable with composer

[fballiano]

I think that who uses those themes is not on the latest version or didn't install via composer, so they shouldn't be harmed but a removal from the default package.

Probably the "next-major-release" approach suggested by @colinmollenhour is the safest.