Magento-lts: Grouped.php method getFinalPrice() should not return false

Created on 6 May 2020  ·  3Comments  ·  Source: OpenMage/magento-lts

CatalogIndex/Model/Data/Grouped.php method getFinalPrice() should not return false to be compatible firth parent method.

Cleanup

Most helpful comment

It is interesting, just to review code ... isn't it ;)

Oh man, I saw things which cant be unseen during the recent reviews. So many stupid things like „usually return float but in some edge case return $this”.

All 3 comments

It is interesting, just to review code ... isn't it ;)

It is interesting, just to review code ... isn't it ;)

Oh man, I saw things which cant be unseen during the recent reviews. So many stupid things like „usually return float but in some edge case return $this”.

Ref #946

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Adel-Magebinary picture Adel-Magebinary  ·  3Comments

waynetheisinger picture waynetheisinger  ·  6Comments

ioweb-gr picture ioweb-gr  ·  6Comments

AlterWeb picture AlterWeb  ·  5Comments

Flyingmana picture Flyingmana  ·  4Comments