Macpass: [Feature Request] Allow for addition of custom icons

[eboddington]

KeePass 2 for Windows allows me to add custom icons for entries. These are displayed fine in MacPass but I can only change to the built-in set of icons, and can't add new ones.

[Couto]

This might sound like a small feature, but it's really helpful to visually identify the correct folder/password from the list. It's actually one of the features that I miss the most.

[eboddington]

Yeah, me too. Given the current development state of MP, it doesn't seem like a glaring omission, but it'd be really nice to have.

[mstarke]

I'm all in favour since it's a rather simple task. The UI needs to be good for adding/removing the icons but the rest ist a no brainer. Since @JoannaOlsen has contributed all the icons I will try to add the feature with the updated icons.

Another note: Keepass allows for custom data and since the icons are all 16x16 i was pondering with the Idea of adding full sizes (with a reasonable maximum size) icons as well and load them. This way MacPass can display the full sized versions instead of those ugly small ones. Problem with this is though that if someone edits the icons outside of MacPass I have to manually remove the special MacPass version since it might not be valid anymore. But for first-class MacPass users this might be of some benefit.

[NicolasSiver]

Also Keepass original supports nice plugin, - Favicon Downloader, most useful plugin that I have used for years.

[mstarke]

There's an issue related to this request: #132

[alakani]

I would really, really like this feature too. I don't mind if it doesn't even have a UI, maybe it can allow dropping a new icon over the one in Inspector, like Finder supports. No high res icons needed either, 16x16 is fine. Also - I think 0.6.2 broke the ability to display custom icons added from KeePass 2, which was working in 0.5.1

[zmcode]

+1 for this request and actually I am in the same situation as @alakani: MacPass version 0.6.2 does not display custom icons added from KeePass 2.

[mstarke]

The missing display of custom icons is a regression in 0.6

[tpluscode]

@zmcode not only it doesn't display custom icons, it also cleared custom icons I had set for folders (entry icons seem to have been kept intact)

[mstarke]

@tpluscode This bug is fixed in the continuous release;

[henriqueccruz]

There's a button called "Download icon" which is always greyed out, no matter what I do.

Downloaded continuous and am a bit clueless about how to do it.
Do I need some plugin to achieve this?

[mstarke]

It's not pushed yet since there are some minor issues that I need to iron out.

[mstarke]

My current approach for this feature:

1. dragging an icon in the inspector icon will use it as a custom icon
2. dragging an icon onto the icon selection popup will add it as a custom icon
3. the download button in the icon selection popup will download the websites favicon as a new custom icon.
4. dragging a custom icon out of the icon selection popup will delete that icon from the database
5. custom icons in the icon selection popup have a context menu with one entry "delete"
6. pressing alt while the icon selection popup is open will show remove buttons on all custom icons and a click on those will delete the icon

I've already implemented 2. and 3. and now are onto 1. 4. 5. and 6.

[mstarke]

1. and 5. are working as well so basic functionality for adding, setting and deleting custom icons works. That leaves 4. and 6.

[mstarke]

I've decided to leave out 4 and 6 for now since the functionality is there. Further improvements should be documented in a different issue.

[kud]

Hey @mstarke . I would like to understand where is the progress of this feat, because I don't understand how to define an icon for a folder. Thanks!

[kud]

Oh okay, I think I got it. I had a bug that selecting the group also selecting the first entry and I never saw the folder edition in inspector, it always opened the entry edition.

[mstarke]

This "bug" is a problem of the auto-seleciton of the last selected entry in a group. This leads to the cumbersome way of re-clicking on the group to get the group selection to show up. This needs a lot of rework which I've been pushing out to the point where I can refactor the UI to remove any old cruft and raise the deployment target to 10.13 or higher.

[kud]

Yes, that's it!

Thank you @mstarke !