Lvgl: letter 賶 Arabic processing error

Created on 15 Dec 2020  路  5Comments  路  Source: lvgl/lvgl

Describe the bug
when Having an Arabic font that covers only the Arabic Presentation Forms-B.
the letter 賶 produces a missing glyph error.
explain
I found an error in the table of Unicode at ap_chars_map[] at lv_txt_ap.cfile
fix
at line 72
add this
{39, 0xFEF0, 0, 0, -1, {1, 0}}, // 賶

I didn't want to delete the line existing at 72. because even if I think it is a mistake and the Unicode there is a duplicate of the one at 74
but yet. it doesn't harm being there.
and maybe it works fine with other forms for Persian writing, I don't know we should ask Mr. Hamid who wrote the file.
so just adding that line fixes it.
Screenshots
look at the keyboard and the missing letter.
before
image

after
image

Most helpful comment

@ashrafkamel5
I've fixed both the dropdown and window, thanks for the report.

@hamidrm
Thanks for looking into it.
Could send a PR to fix that Arabic letter.

All 5 comments

Thank you!
@hamidrm, could you take a look at this?

@ashrafkamel5 You are right! It was my mistake. I thought the glyph of 0x6CC and 0x649 are the same (Although, In the Persian, they are the same!). According to https://en.wikipedia.org/wiki/Arabic_script_in_Unicode, you are right.
So, we should replace your change ({39, 0xFEF0, 0, 0, -1, {1, 0}}, //蹖), with current line 72.
Thank you!
Capture

It's great adding full Arabic support to the library

@kisvegabor there is a small bug at dropdown widget
lv_dropdown_add_option
Doesn't process Arabic letters.
You need to add the lv_txt_ap_proc there

@kisvegabor
and the window's name also needs the same fix 馃槅
lv_win_set_title
it would be repetitive if I did an issue for both of them
hope you just fix them 鉂わ笍
really hyped for the upcoming release!

@ashrafkamel5
I've fixed both the dropdown and window, thanks for the report.

@hamidrm
Thanks for looking into it.
Could send a PR to fix that Arabic letter.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

amirgon picture amirgon  路  6Comments

curly-brace picture curly-brace  路  5Comments

mianhuacar picture mianhuacar  路  5Comments

DeonMarais64 picture DeonMarais64  路  4Comments

larenge2 picture larenge2  路  4Comments