Loris: [Issue Tracker] Dropdown options display order is alpha, not array-defined

[christinerogers]

The Priority selection filter in the Issue Tracker presents dropdown options in alphabetical order, but should display them in the same order defined in the php array - the order of priority. See code snippet below

I suspect this is a known issue _in multiple modules_ with an easy fix.

Is there already a way we should be forcing the order of these dropdowns?
cc @johnsaigle @HenriRabalais

Occurs with Chrome, Firefox, Safari... on Demo and on test-dev-loris(23 branch), tested on mac.

Order defined in the php array:

        $priorities = array(
            'normal'    => 'Normal',
            'high'      => 'High',
            'urgent'    => 'Urgent',
            'immediate' => 'Immediate',
        );

Order as actually displayed :

Related (sort of) to: #4602 - see @johnsaigle's comment recognizing this sort-order behaviour/implication in 2019

[johnsaigle]

As you said this should probably be case-by-case. Maybe there is a generic way to specify sorting for dropdown elements within React? @HenriRabalais @maltheism @zaliqarosli maybe one of you would know?

[HenriRabalais]

IIRC, @ridz1208 had made a PR to enforce alphabetical ordering. I'm not sure if there's a way to override this at the moment.

[johnsaigle]

Is there a way to extend/modify a component so that a sort ordering can be specified via a param?

[ridz1208]

@HenriRabalais yeah I had but I forgot how to use it. I do remember adding that though

[HenriRabalais]

Looks like there might be - it's not commented in the code, but I think the props sortByValue determines if the drop down values are sorted alphabetically. The value defaults to true, so a value of false would have to be passed to the SelectElement for the prop sortByValue.

https://github.com/aces/Loris/blob/master/jsx/Form.js#L309

[johnsaigle]

OK so it sounds like we can make a PR to fix the issue tracker without much trouble in this case and that we have a lot of flexibility in general.

@christinerogers do you have any other examples of this?

[christinerogers]

@johnsaigle : sure, more examples --

• issue tracker: Status: New, Assigned, Closed
  I also scanned a few modules and easily turned up:
• [ all modules? ] Subproject -- probably better to group at least by project than list in alpha order.
• [imaging modules] Scan type (t1, t2, fMRI, DTI)
• [ Genomic browser subtabs ] “SNPs found”: current order is “Yes”, “No”
  And more generically, dropdown option order would have changed upon Reactification for:
• All "Yes", "No" dropdowns become "No", "Yes"
• any dropdown with "Other" or "NA" - typically we want these last position (e.g. in Genomic Browser)

[johnsaigle]

thanks!

[christinerogers]

Note: this is an effect of the default change from #3952 -- took effect in the August 2019 release 21