Lmms: Settings should not use automatable widgets

[Sawuare]

Settings currently use LedCheckbox which inherits AutomatableButton which is obviously automatable.

[fschuelke]

My imagination of a workaround would be to add a bool flagging the automation, or are there any better ways?

[Veratil]

My imagination of a workaround would be to add a bool flagging the automation, or are there any better ways?

Alternative is split the class and have a normal Button with AutomatableButton inheriting it. This seems like a smarter way to go to me. It'd be less work to update AutomatableButton to add a flag, but forgetting a flag here or there could cause problems. Splitting the class is clearer, more readable, and more maintainable in the long run.

[fschuelke]

but forgetting a flag here or there could cause problems.

we could prevent this by setting a default value for the flag in the class constructor. This means we only have to look for UI components that should not be automatable and add the flag there (which we would have to do anyways), but your solution makes more sense looking from OOP

[tresf]

Why is this a bug? It's more like an enhancement. It's not like you can Ctrl + Drag from a Modal dialog.

[SecondFlight]

It's not like you can Ctrl + Drag from a Modal dialog.

You mean like this?

[tresf]

I stand corrected. Tested on Mac before commenting too. 😆

[JohannesLorenz]

Concerning criticality... I think this is not critical, so must not be fixed in stable-1.2. Can anyone confirm this?

[Sawuare]

@JohannesLorenz Yes, this is not critical.